Skip to content

Commit

Permalink
fix(cli): org:search:dump issues when dump is fetched across multiple…
Browse files Browse the repository at this point in the history
  • Loading branch information
fbeaudoincoveo committed Jun 21, 2024
1 parent 6187375 commit 2ef81a1
Show file tree
Hide file tree
Showing 10 changed files with 163 additions and 22 deletions.
155 changes: 140 additions & 15 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"@actions/github": "5.1.1",
"@commitlint/config-conventional": "17.6.1",
"@commitlint/lint": "17.6.1",
"@coveo/platform-client": "52.1.0",
"@coveo/platform-client": "54.9.3",
"@coveo/semantic-monorepo-tools": "2.4.28",
"@coveord/release": "1.0.0",
"@npmcli/arborist": "6.2.8",
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-e2e/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"@babel/preset-env": "7.21.5",
"@babel/preset-typescript": "7.21.5",
"@coveo/cli": "3.2.6",
"@coveo/platform-client": "52.1.0",
"@coveo/platform-client": "54.9.3",
"abortcontroller-polyfill": "1.7.5",
"async-retry": "1.3.3",
"babel-jest": "29.5.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/commons/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"dependencies": {
"@amplitude/analytics-node": "^1.3.3",
"@amplitude/analytics-types": "^2.1.2",
"@coveo/platform-client": "52.1.0",
"@coveo/platform-client": "54.9.3",
"@oclif/core": "1.24.0",
"abortcontroller-polyfill": "1.7.5",
"chalk": "4.1.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"@amplitude/identify": "^1.9.0",
"@coveo/cli-commons": "2.9.3",
"@coveo/cli-plugin-source": "2.3.3",
"@coveo/platform-client": "52.1.0",
"@coveo/platform-client": "54.9.3",
"@oclif/core": "1.24.0",
"@oclif/plugin-help": "5.1.23",
"@oclif/plugin-plugins": "2.1.12",
Expand Down
15 changes: 15 additions & 0 deletions packages/cli/core/src/commands/org/search/dump.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,21 @@ describe('org:search:dump', () => {
mockedSearch.mockReset();
});

test
.do(() => {
mockReturnNumberOfResults(0);
})
.stdout()
.stderr()
.command(['org:search:dump', '-s', 'the_source_1'])
.it('should pass maximumAge 0 as a search parameter', () =>
expect(mockedSearch).toHaveBeenCalledWith(
expect.objectContaining({
maximumAge: 0,
})
)
);

test
.do(() => {
mockReturnNumberOfResults(0);
Expand Down
1 change: 1 addition & 0 deletions packages/cli/core/src/commands/org/search/dump.ts
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,7 @@ export default class Dump extends CLICommand {
const results = (await params.client.search.query({
aq: this.getFilter(params, rowId),
debug: true,
maximumAge: 0,
organizationId: params.organizationId,
numberOfResults: this.numberOfResultPerQuery,
sortCriteria: '@rowid ascending',
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/source/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
],
"dependencies": {
"@coveo/cli-commons": "2.9.3",
"@coveo/platform-client": "52.1.0",
"@coveo/platform-client": "54.9.3",
"@coveo/push-api-client": "4.0.1",
"@oclif/core": "1.24.0",
"@oclif/plugin-help": "5.1.23",
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/atomic/create-atomic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"access": "public"
},
"dependencies": {
"@coveo/platform-client": "52.1.0",
"@coveo/platform-client": "54.9.3",
"abortcontroller-polyfill": "1.7.5",
"detect-indent": "7.0.1",
"https-proxy-agent": "5.0.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/vue/create-headless-vue/template/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"zod": "^3.19.1"
},
"devDependencies": {
"@coveo/platform-client": "^52.1.0",
"@coveo/platform-client": "54.9.3",
"@rushstack/eslint-patch": "^1.1.4",
"@types/node": "18.16.3",
"@vitejs/plugin-vue": "^4.0.0",
Expand Down

0 comments on commit 2ef81a1

Please sign in to comment.