Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding check for usher arg to dependency checks so pangolin doesn't b… #323

Merged
merged 1 commit into from
Oct 20, 2021
Merged

adding check for usher arg to dependency checks so pangolin doesn't b… #323

merged 1 commit into from
Oct 20, 2021

Conversation

aineniamh
Copy link
Member

…reak if usher arg not specified for issue #277

@aineniamh aineniamh requested a review from rmcolq October 19, 2021 16:32
rmcolq
rmcolq approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@rmcolq rmcolq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I was going to suggest we could leave out pangoLEARN as a dependancy when in usher mode, but we can't because of the designation hash...
Like you say, would be great to have usher in github action too

@aineniamh aineniamh merged commit ffc229b into master Oct 20, 2021
@aineniamh aineniamh deleted the dev_aine branch October 21, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmcolq rmcolq rmcolq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aineniamh @rmcolq