feat: add fullscreen capability #142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelobguido
requested changes
Dec 18, 2023
Comment on lines
+360
to
+371
| def fullscreen(): | ||
| global WIDTH, HEIGHT, SCREEN, width_temp, height_temp | ||
| if bool(SCREEN.get_flags() & pygame.FULLSCREEN): # Check if FULLSCREEN flag is activated | ||
| SCREEN = pygame.display.set_mode((width_temp, height_temp)) # Returns window size to original | ||
| WIDTH, HEIGHT = width_temp, height_temp | ||
| draw_grid() | ||
| else: | ||
| width_temp, height_temp = WIDTH, HEIGHT | ||
| SCREEN = pygame.display.set_mode((0, 0), pygame.FULLSCREEN) # Enables FULLSCREEN flag | ||
| WIDTH, HEIGHT = pygame.display.get_surface().get_size() | ||
| draw_grid() | ||
|
|
There was a problem hiding this comment.
There is a problem in this function. The way we are placing objects at the screen depends on the WIDTH and HEIGHT. When you die and resets at fullscreen, the game is crashing. It happens when you enter fullscreen and press start too.
|
Did this feature exist when we froze v1.0.0? |
I think not. |
|
If was not selected into v1.1.0, it shoukd not enter the release, unless we can vote for new features in the upcoming release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduce the addition of the fullscreen function, a new feature designed to enhance user experience in the Sucury game. This function enables players to easily toggle between fullscreen and windowed modes, offering a more immersive gaming experience that can adapt to individual player preferences.
The function is integrated to respect the game's original dimensions when switching back from fullscreen to windowed mode. The global variables WIDTH, HEIGHT, and SCREEN are dynamically adjusted to match the current display mode.