Fix loss of precision encoding some double values to JSON (#206) #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some `double` numbers stored in Fleece would be improperly rounded (too few digits of precision) when written to JSON or otherwise converted to strings. The fix makes a slight change to the Fleece binary format, using a previously unused bit in a float value, but it's backwards compatible. Fixes #206
borrrden
approved these changes
Jan 31, 2024
Dushistov
pushed a commit
to Dushistov/fleece
that referenced
this pull request
May 8, 2024
) (couchbase#207) Some `double` numbers stored in Fleece would be improperly rounded (too few digits of precision) when written to JSON or otherwise converted to strings. The fix makes a slight change to the Fleece binary format, using a previously unused bit in a float value, but it's backwards compatible. Fixes couchbase#206
Dushistov
pushed a commit
to Dushistov/fleece
that referenced
this pull request
Jun 2, 2024
…uchbase#206) (couchbase#207)" This reverts commit cd5a03f.
Dushistov
added a commit
to Dushistov/fleece
that referenced
this pull request
Jun 3, 2024
…uchbase#206) (couchbase#207)" This reverts commit b915faf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
doublenumbers stored in Fleece would be improperly rounded (too few digits of precision) when written to JSON or otherwise converted to strings.The fix makes a slight change to the Fleece binary format, using a previously unused bit in a float value, but it's backwards compatible.
Fixes #206