Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use c4query_columnTitle to get column names #2229

Closed
pasin opened this issue Nov 19, 2018 · 7 comments
Closed

Use c4query_columnTitle to get column names #2229

pasin opened this issue Nov 19, 2018 · 7 comments
Assignees
Milestone

Comments

@pasin
Copy link
Contributor

pasin commented Nov 19, 2018

LiteCore has implemented c4query_columnTitle for getting column names. CBL should use that instead of generating the column names by itself.

@pasin
Copy link
Contributor Author

pasin commented Dec 1, 2018

This has been done as part of #2228.

@pasin pasin closed this as completed Dec 1, 2018
@pasin pasin added this to the Iridium milestone Dec 1, 2018
@borrrden
Copy link
Member

borrrden commented Apr 9, 2019

Is it just me or does this completely ignore aliases when generating column names? I think c4query_columnTitle needs to define exactly what it provides and what it does not.

@pasin
Copy link
Contributor Author

pasin commented Apr 9, 2019

@borrrden We have a key projecting test which also tests alias. Can you point me to .NET test that the alias doesn't work?

@borrrden
Copy link
Member

borrrden commented Apr 9, 2019

This one fails. LiteCore returns '_id' for 'mainDocID' and '_id #2' for 'secondaryDocID'

@pasin
Copy link
Contributor Author

pasin commented Apr 9, 2019

@jayahariv Can you check on this?

@borrrden
Copy link
Member

Furthermore, if a database has an alias, the improper name will be returned (the real name of the database instead of the alias)

@jayahariv
Copy link
Contributor

jayahariv commented Apr 10, 2019

seems like iOS tests are passing in both release/iridium and master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants