Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tvOS release package #1024

Closed
zgramana opened this issue Jan 8, 2016 · 9 comments
Closed

Add tvOS release package #1024

zgramana opened this issue Jan 8, 2016 · 9 comments
Assignees
Milestone

Comments

@zgramana
Copy link
Contributor

zgramana commented Jan 8, 2016

See #918

@snej
Copy link
Contributor

snej commented Jan 18, 2016

Dependent on #1042 — I forgot I hadn't merged the tvOS build support in the Xcode project into release/1.1 or master.

@zgramana
Copy link
Contributor Author

Did you meant release/1.2 above?

@snej
Copy link
Contributor

snej commented Jan 19, 2016

Yeah.

Some build notes for Michael, since I ended up using a different/better approach than what I did for the 1.1.1-appletv branch:

  • There aren't any new targets for tvOS. Instead, the iOS targets can now build tvOS too. You just need to use the -destination flag to xcodebuild to specify which platform to build for.
  • Build output will be in Release-iOS-universal as usual, or Release-tvOS-universal for tvOS.
  • There's a chance the capitalization is different in those directory names, since I ended up changing a lot of the configuration behind them ... if you get file-not-found errors on the build bot, take a look at the case.

@michaelkwok
Copy link
Contributor

I will update the build script for this. Couple questions before I make the changes.

  1. With this change, I take it we don't need to do any copying of libCBLForestDBStorage.a since it's no longer generating Release-CBLForestDBStorage-ios-universal
  2. Do we still need to create 2 packages for iOS vs tvOS for release?

@snej
Copy link
Contributor

snej commented Jan 19, 2016

libCBLForestDBStorage.a is in Release-iOS-universal.

Yes, we probably want a separate package/zip for tvOS.

@michaelkwok
Copy link
Contributor

Great, thanks!

@michaelkwok
Copy link
Contributor

Actually, what I meant to say was that "libCBLForestDBStorage.a is in Release-iOS-universal" now, we probably don't need to copy into "Release-iOS-universal/Extras" like we did before this change. Let me know if I still need to copy or move it under Extras?

@snej
Copy link
Contributor

snej commented Jan 19, 2016

In the zip archive it should be at top-level, next to the .framework, not in the Extras folder. Thanks!

@michaelkwok
Copy link
Contributor

I have added tvOS to release/1.2.0 and master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants