Used pytest SkipIf to skip the two tests causing the BucketNotFoundException for Issue#1 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackson-drew
changed the title
Co-Author Xuan Hien Pham phamxuanhien02@gmail.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here was caused by the testing being unable to locate a bucket at the given Couchbase connection string. This is configured by the user in the
.envfile, however the way this is setup now will cause testing to fail if the user does not have a valid bucket set up. While replicating this error we realized invalidCOUCHBASE_CONNECTION_STRING,COUCHBASE_USERNAME,COUCHBASE_PASSWORD, orCOUCHBASE_DEFAULT_BUCKETwill all cause testing to fail.Replication of Issue:
Our solution involved skipping the test if the user had not defined any of the aforementioned
.envvariables. We did this with a custom method which checks if they have all been defined by the user, and to only run testing once that has happened, skipping teststest_indexandtest_create_and_get_documentif.envvariables are not defined, this puts the exception as a responsibility of the user, and no longer a default of the template.Default testing when the user has not defined
.envvalues: