Avoid caching pageviews data #1849

kungfux · 2024-07-09T18:38:15Z

Type of change

Bug fix (non-breaking change which fixes an issue)

Description

To retrieve pageviews we send GET request from _includes/pageviews/goatcounter.html. When PWA is enabled, the response is cached and so the pageview counter is not updated as expected.

Additional context

I see two possible ways to fix this behavior:

Make GET requests unique
Avoid caching these requests

Option 1 is easy fix, applied in this PR but has it's drawbacks e.g. utilize cache.

Option 2 seems preferable. However, it requires changes in _javascript/pwa/sw.js to support non-relative paths.
Please let me know your thoughts on this.

cotes2020

The previous solution (before 8362564) was to filter GA URLs by configuration file data/swcache.js.

jekyll-theme-chirpy/assets/js/data/swcache.js

Lines 49 to 54 in 728094d

    
           /* Requests that include the following path will be banned */ 
        
           const denyUrls = [ 
        
               {% if site.google_analytics.pv.cache_path %} 
        
                   '{{ site.google_analytics.pv.cache_path | absolute_url }}' 
        
               {% endif %} 
        
           ];

Now we can restore this configuration in assets/js/data/swconf.js

kungfux · 2024-07-09T19:48:22Z

I forgot that we used to have pageviews. Thanks for reminding me.

I have published changes as suggested. Please let me know what do you think.

cotes2020

Defining in denyPaths doesn't seem to fit because it sets relative paths.

We should define a new variable denyUrls to store these CORS URLs.

Also, _javascript/pwa/sw.js needs to be modified accordingly.

_javascript/pwa/sw.js

_config.yml

assets/js/data/swconf.js

## [7.1.0](v7.0.1...v7.1.0) (2024-08-27) ### Features * add Bluesky social links ([#1759](#1759)) ([0102aba](0102aba)) * add Reddit social option ([#1836](#1836)) ([8673e13](8673e13)) * add Threads social links ([#1837](#1837)) ([e3a78b6](e3a78b6)) * **analytics:** add fathom analytics ([#1913](#1913)) ([befc4ce](befc4ce)) * **dev:** add vscode tasks ([#1843](#1843)) ([e4db1a1](e4db1a1)) * **dev:** support vscode dev-container ([#1781](#1781)) ([1e3d4a6](1e3d4a6)) * **ui:** improve block quote layout ([80bd792](80bd792)) * **ui:** improve visibility of inline code ([#1831](#1831)) ([c876731](c876731)) * **ui:** make `info-prompt` icon looks like the letter "i" ([#1835](#1835)) ([a07a57e](a07a57e)) * **ui:** set `<kbd>` font to 'Lato' ([64c7262](64c7262)) ### Bug Fixes * adapt the giscus localization parameter ([#1810](#1810)) ([0709854](0709854)) * avoid caching pageviews data ([#1849](#1849)) ([979f86c](979f86c)) * remove extra dual-mode images from lightbox ([#1883](#1883)) ([5c5910f](5c5910f))

github-actions · 2024-08-27T07:29:25Z

🎉 This issue has been resolved in version 7.1.0 🎉

The release is available on:

v7.1.0
GitHub release

Your semantic-release bot 📦🚀

## [7.1.0](cotes2020/jekyll-theme-chirpy@v7.0.1...v7.1.0) (2024-08-27) ### Features * add Bluesky social links ([cotes2020#1759](cotes2020#1759)) ([0102aba](cotes2020@0102aba)) * add Reddit social option ([cotes2020#1836](cotes2020#1836)) ([8673e13](cotes2020@8673e13)) * add Threads social links ([cotes2020#1837](cotes2020#1837)) ([e3a78b6](cotes2020@e3a78b6)) * **analytics:** add fathom analytics ([cotes2020#1913](cotes2020#1913)) ([befc4ce](cotes2020@befc4ce)) * **dev:** add vscode tasks ([cotes2020#1843](cotes2020#1843)) ([e4db1a1](cotes2020@e4db1a1)) * **dev:** support vscode dev-container ([cotes2020#1781](cotes2020#1781)) ([1e3d4a6](cotes2020@1e3d4a6)) * **ui:** improve block quote layout ([80bd792](cotes2020@80bd792)) * **ui:** improve visibility of inline code ([cotes2020#1831](cotes2020#1831)) ([c876731](cotes2020@c876731)) * **ui:** make `info-prompt` icon looks like the letter "i" ([cotes2020#1835](cotes2020#1835)) ([a07a57e](cotes2020@a07a57e)) * **ui:** set `<kbd>` font to 'Lato' ([64c7262](cotes2020@64c7262)) ### Bug Fixes * adapt the giscus localization parameter ([cotes2020#1810](cotes2020#1810)) ([0709854](cotes2020@0709854)) * avoid caching pageviews data ([cotes2020#1849](cotes2020#1849)) ([979f86c](cotes2020@979f86c)) * remove extra dual-mode images from lightbox ([cotes2020#1883](cotes2020#1883)) ([5c5910f](cotes2020@5c5910f))

kungfux marked this pull request as ready for review July 9, 2024 18:38

cotes2020 reviewed Jul 9, 2024

View reviewed changes

kungfux force-pushed the bugfix/prevent-pageviews-caching branch from f8129fb to 3d501cc Compare July 9, 2024 19:46

cotes2020 reviewed Jul 10, 2024

View reviewed changes

kungfux marked this pull request as draft July 10, 2024 20:29

kungfux force-pushed the bugfix/prevent-pageviews-caching branch 4 times, most recently from 455b05f to 0b1f717 Compare July 11, 2024 22:40

kungfux commented Jul 11, 2024

View reviewed changes

_javascript/pwa/sw.js Show resolved Hide resolved

kungfux marked this pull request as ready for review July 11, 2024 22:44

cotes2020 requested changes Jul 15, 2024

View reviewed changes

_config.yml Outdated Show resolved Hide resolved

assets/js/data/swconf.js Outdated Show resolved Hide resolved

fix: prevent pageview requests caching

5911624

kungfux force-pushed the bugfix/prevent-pageviews-caching branch from 0b1f717 to 5911624 Compare July 17, 2024 04:25

cotes2020 added 2 commits July 17, 2024 23:21

refactor: improve data definitions

65d467f

refactor: update sw.js

d0dc38d

cotes2020 approved these changes Jul 17, 2024

View reviewed changes

cotes2020 merged commit 979f86c into cotes2020:master Jul 17, 2024
7 checks passed

cotes2020 changed the title ~~bugfix: prevent pageview requests caching~~ Avoid caching pageviews data Jul 17, 2024

kungfux deleted the bugfix/prevent-pageviews-caching branch July 17, 2024 17:21

gudtldn pushed a commit to gudtldn/gudtldn.github.io that referenced this pull request Jul 26, 2024

fix: avoid caching pageviews data (cotes2020#1849)

1bb5f36

github-actions bot added the released label Aug 27, 2024

RoboMico pushed a commit to RoboMico/robomico.cn that referenced this pull request Sep 22, 2024

fix: avoid caching pageviews data (cotes2020#1849)

575bcbc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid caching pageviews data #1849

Avoid caching pageviews data #1849

kungfux commented Jul 9, 2024

cotes2020 left a comment •

edited

Loading

kungfux commented Jul 9, 2024 •

edited

Loading

cotes2020 left a comment •

edited

Loading

github-actions bot commented Aug 27, 2024

	/* Requests that include the following path will be banned */
	const denyUrls = [
	{% if site.google_analytics.pv.cache_path %}
	'{{ site.google_analytics.pv.cache_path \| absolute_url }}'
	{% endif %}
	];

Avoid caching pageviews data #1849

Avoid caching pageviews data #1849

Conversation

kungfux commented Jul 9, 2024

Type of change

Description

Additional context

cotes2020 left a comment • edited Loading

Choose a reason for hiding this comment

kungfux commented Jul 9, 2024 • edited Loading

cotes2020 left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Aug 27, 2024

cotes2020 left a comment •

edited

Loading

kungfux commented Jul 9, 2024 •

edited

Loading

cotes2020 left a comment •

edited

Loading