-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated URLs should be encoded properly #835
Comments
👋 Hi @ruzickap, This issue is being automatically closed because it does not follow the issue template. Please DO NOT open another similar issue, try to edit the current issue according to the template, then it will be reopened automatically. |
10 tasks
NichtsHsu
added a commit
to NichtsHsu/nichtshsu.github.io
that referenced
this issue
Jan 3, 2023
cotes2020
added a commit
that referenced
this issue
Jan 6, 2023
sanjidnet
pushed a commit
to sanjidnet/sanjidnet.github.io
that referenced
this issue
Jan 9, 2023
linkliu
pushed a commit
to linkliu/game-tech-post-old
that referenced
this issue
Jan 9, 2023
Resolves cotes2020#835 (cherry picked from commit f2d2858)
Gaur4vGaur
added a commit
to Gaur4vGaur/Gaur4vGaur.github.io
that referenced
this issue
Jan 28, 2023
author Gaurav Gaur <Gaur4vGaur@users.noreply.github.com> 1673866009 +0000 committer Gaurav Gaur <Gaur4vGaur@users.noreply.github.com> 1674946094 +0000 Jan23 upstream merge (#7) * chore(editorconfig): keep trailing spaces in Markdown (cotes2020#830) * feat(i18n): add Czech language (cotes2020#833) * fix: correct encoding of spaces in share URLs (cotes2020#835) Resolves cotes2020#835 * fix: post's image would cover the PWA update alert * feat(i18n): add Finnish translations (cotes2020#843) * docs: update tutorials - remove outdated content - append instructions for SASS overrides (cotes2020#827) * chore(deps): lock `jekyll-sass-converter` to `v2.x` on Linux-musl (cotes2020#829) Also, make the division formula backward compatible with `jekyll-sass-converter 2.x` (cotes2020#848, cotes2020#849) Ref: https://github.com/jekyll/jekyll-sass-converter#migrate-from-2x-to-3x * chore(bundler): deprecate `:install_if` option in Gemfile * feat(i18n): add Italian translation (cotes2020#850) * fix: copy command line incomplete(`.gp` part) Co-authored-by: Jarda Beran <jaroslav.beran@proton.me> Co-authored-by: MatyIRG <100308274+MatyIRG@users.noreply.github.com> Co-authored-by: Cotes Chung <11371340+cotes2020@users.noreply.github.com> Co-authored-by: Kalle Lahtinen <39586081+Kaaponen@users.noreply.github.com> Co-authored-by: Eduardo <85281180+CsaProtocol@users.noreply.github.com> feat(i18n): add Czech language (cotes2020#833) fix: correct encoding of spaces in share URLs (cotes2020#835) Resolves cotes2020#835 fix: post's image would cover the PWA update alert feat(i18n): add Finnish translations (cotes2020#843) chore(bundler): deprecate `:install_if` option in Gemfile feat(i18n): add Italian translation (cotes2020#850)
Gaur4vGaur
added a commit
to Gaur4vGaur/Gaur4vGaur.github.io
that referenced
this issue
Feb 3, 2023
author Gaurav Gaur <Gaur4vGaur@users.noreply.github.com> 1675074395 +0000 committer Gaurav Gaur <Gaur4vGaur@users.noreply.github.com> 1675445316 +0000 parent 6c35647 author Gaurav Gaur <Gaur4vGaur@users.noreply.github.com> 1675074395 +0000 committer Gaurav Gaur <Gaur4vGaur@users.noreply.github.com> 1675445269 +0000 parent 6c35647 author Gaurav Gaur <Gaur4vGaur@users.noreply.github.com> 1675074395 +0000 committer Gaurav Gaur <Gaur4vGaur@users.noreply.github.com> 1675445201 +0000 parent 6c35647 author Gaurav Gaur <Gaur4vGaur@users.noreply.github.com> 1675074395 +0000 committer Gaurav Gaur <Gaur4vGaur@users.noreply.github.com> 1675445170 +0000 parent 6c35647 author Gaurav Gaur <Gaur4vGaur@users.noreply.github.com> 1675074395 +0000 committer Gaurav Gaur <Gaur4vGaur@users.noreply.github.com> 1675445041 +0000 progress with pipes and filters pattern feat: add shimmer background when image loads feat: set preview image ratio to 1.91 : 1 fix: `og:image` will be incorrect if the image uses a cross-domain URL feat: support dark and light mode images (cotes2020#481) refactor: unify the border radius of blocks scope: code blocks, prompts, images, and videos feat: add `rel="me"` to Mastodon sidebar contact links for verification (cotes2020#807) This will enable verification with Mastodon by including the `rel="me"` attribute. https://docs.joinmastodon.org/user/profile/#verification Co-authored-by: Cotes Chung <11371340+cotes2020@users.noreply.github.com> chore: hide blur edge of LQIP images chore(tools): checkout latest tag on initialization chore(editorconfig): keep trailing spaces in Markdown (cotes2020#830) feat(i18n): add Czech language (cotes2020#833) fix: correct encoding of spaces in share URLs (cotes2020#835) Resolves cotes2020#835 fix: post's image would cover the PWA update alert feat(i18n): add Finnish translations (cotes2020#843) chore(bundler): deprecate `:install_if` option in Gemfile feat(i18n): add Italian translation (cotes2020#850) fix: copy command line incomplete(`.gp` part) feat(i18n): add Arabic translation (cotes2020#857) chore(deps): liquid(v4.0.4) is compatible with ruby 3.2 (cotes2020#854) See: jekyll/jekyll#9231 chore: ignore gem lock file in user-end refactor: optimize tab cursor position calculation fix: prompt with nested blockquotes renders incorrectly (cotes2020#846) Resolves cotes2020#846 chore(release): 5.5.0 fix: the icon position of the prompts in the list is incorrect chore(release): 5.5.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist
master
branch.Describe the bug
To Reproduce
Steps to reproduce the behavior:
Steps to reproduce the behavior:
I checked the https://chirpy.cotes.page/posts/getting-started/ and it seems like some URLs are not properly "coded":
I'm pointing to the
Getting Started - Chirpy
- which should be using%20
in the URL.If I fetch the generated URL I'm getting:
Expected behavior
Screenshots
Environment
ruby -v
gem -v
bundle -v
bundle exec jekyll -v
bundle info jekyll-theme-chirpy
Desktop
Smartphone
Additional context
The text was updated successfully, but these errors were encountered: