Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diff to code when relevant. #1296

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Add diff to code when relevant. #1296

merged 1 commit into from
Dec 6, 2022

Conversation

xavierlepretre
Copy link
Contributor

@xavierlepretre xavierlepretre commented Dec 1, 2022

This PR beautifies many code snippets where new lines are adding in between others. The look is improved with the use of diff- so that the reader is visually guided to the changes instead of being only presented with the end-result.

If it looks like there is some misalignment in the markdown, that's on purpose because this misalignment renders correctly.

R1: Internal review (B9lab)

  • Technical review
    • requested
    • completed
  • Language review
    • requested
    • completed

R2: External review

  • Technical review
    • requested
    • completed
  • Language review
    • requested
    • completed

R3: Internal QA review (B9lab)

  • Technical review
    • requested
    • completed
  • Language review
    • requested
    • completed

R4: Final external QA review

  • Technical review
    • requested
    • completed
  • Language review
    • requested
    • completed

RC: Release Candidate

  • Ready to be merged

@coldice coldice marked this pull request as ready for review December 6, 2022 14:49
@coldice coldice merged commit 6f8afa5 into master Dec 6, 2022
@coldice coldice deleted the xl-diff-code branch December 6, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants