feat: add the ability to query the hash associated with an IBC denom trace #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently have commands to query all IBC denom traces or a specific IBC denom trace based off a given hash, but we are lacking the ability to query a hash based off a specific IBC denom trace. This adds a new query to the `Provider` interface that allows users to query this IBC denom trace information for a given chain and hash.
Reecepbcups
approved these changes
Mar 29, 2024
| Short: "query the denom hash info from a given denom trace", | ||
| Args: withUsage(cobra.ExactArgs(2)), | ||
| Example: strings.TrimSpace(fmt.Sprintf(` | ||
| $ %s query denom-hash osmosis transfer/channel-0/uatom |
There was a problem hiding this comment.
TIL this is the IBC denom trace and than you can take this and convert to the hash. Cool!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have commands to query all IBC denom traces or a specific IBC denom trace based off a given hash, but we are lacking the ability to query a hash based off a specific IBC denom trace. This adds a new query to the
Providerinterface that allows users to query this IBC denom trace information for a given chain and hash.Closes #1416