Standalone to consumer changeover - recycle existing transfer channel #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsumer chain upgrade height
…o jstr/onchain_upgrade_to_consumer_chain_840
…merge conflict fix issue
Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com>
Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
shaspitz
requested review from
jtremback,
mpoke,
sainoe,
MSalopek,
mmulji-ic,
glnro and
yaruwangway
as code owners
MSalopek
approved these changes
Apr 19, 2023
jtremback
reviewed
Apr 19, 2023
| @@ -111,7 +111,7 @@ func (k Keeper) Slash(ctx sdk.Context, addr sdk.ConsAddress, infractionHeight, p | |||
|
|
|||
| // If this is a previously standalone chain and infraction happened before the changeover was completed, | |||
| // slash only on the standalone staking keeper. | |||
| if k.IsPrevStandaloneChain() && infractionHeight < k.FirstConsumerHeight(ctx) { | |||
| if k.IsPrevStandaloneChain(ctx) && infractionHeight < k.FirstConsumerHeight(ctx) { | |||
| k.standaloneStakingKeeper.Slash(ctx, addr, infractionHeight, power, slashFactor, stakingtypes.InfractionEmpty) | |||
There was a problem hiding this comment.
We need to dig into how exactly consumer chains using the democracy module or other things will populate standaloneStakingKeeper
There was a problem hiding this comment.
What do you mean? That's the staking module with the native token from when the chain was a standalone chain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows previously standalone chains to use the already existing transfer channel from the standalone chain
Linked issues
Closes: #782
Epic: #756
Type of change
If you've checked more than one of the first three boxes, consider splitting this PR into multiple PRs!
Feature: Changes and/or adds code behavior, irrelevant to bug fixesFix: Changes and/or adds code behavior, specifically to fix a bugRefactor: Changes existing code style, naming, structure, etc.Testing: Adds testingDocs: Adds documentationRegression tests
Existing handshake tests like
TestOnChanOpenAckNew behavior tests
CRUD unit tests, and new integration test in
changeover.goVersioning Implications
If the above box is checked, which version should be bumped?
MAJOR: Consensus breaking changes to both the provider and consumers(s), including updates/breaking changes to IBC communication between provider and consumer(s)MINOR: Consensus breaking changes which affect either only the provider or only the consumer(s)PATCH: Non consensus breaking changesTargeting
Please select one of the following: