Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add getters for testing epochs in Gaia #1739

Merged
merged 2 commits into from
Apr 3, 2024
Merged

test: Add getters for testing epochs in Gaia #1739

merged 2 commits into from
Apr 3, 2024

Conversation

sainoe
Copy link
Contributor

@sainoe sainoe commented Mar 28, 2024

Description

Add some getters in the integrations test suite to test ICS epochs in Gaia.

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@sainoe sainoe requested a review from a team as a code owner March 28, 2024 15:23
@sainoe sainoe changed the title test: Add getters for testing ICS epochs in Gaia test: Add getters for testing epochs in Gaia Mar 28, 2024
@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Mar 28, 2024
p-offtermatt
p-offtermatt approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpoke
Copy link
Contributor

mpoke commented Apr 2, 2024

@sainoe Why is this targeting v4.1.x-lsm instead of main? Don't we need this change in future releases of ICS (e.g., v4.2.x)?

@sainoe
Copy link
Contributor Author

sainoe commented Apr 2, 2024

@mpoke We will only need this for v4.x.x-lsm versions since they're the ones that we will use in Gaia.

@sainoe sainoe changed the base branch from release/v4.1.x-lsm to main April 2, 2024 11:35
@sainoe sainoe changed the base branch from main to release/v4.1.x-lsm April 2, 2024 11:36
@sainoe sainoe force-pushed the sainoe/epoch-intg-test branch from 42dea28 to 3b6fd3e Compare April 2, 2024 13:10
@github-actions github-actions bot added C:x/consumer Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler C:CI Assigned automatically by the PR labeler labels Apr 2, 2024
@sainoe sainoe changed the base branch from release/v4.1.x-lsm to main April 2, 2024 13:10
@sainoe sainoe enabled auto-merge April 3, 2024 06:52
@sainoe sainoe requested review from p-offtermatt and insumity April 3, 2024 06:54
@sainoe sainoe added this pull request to the merge queue Apr 3, 2024
Merged via the queue into main with commit 1a7d03c Apr 3, 2024
16 of 18 checks passed
@sainoe sainoe deleted the sainoe/epoch-intg-test branch April 3, 2024 07:25
mergify bot pushed a commit that referenced this pull request Apr 3, 2024
@sainoe @mergify
test: Add getters for testing epochs in Gaia (#1739)
fea1d22 
* add getter and setters for testing

* add docs

(cherry picked from commit 1a7d03c)
mergify bot pushed a commit that referenced this pull request Apr 3, 2024
@sainoe @mergify
test: Add getters for testing epochs in Gaia (#1739)
d0514af 
* add getter and setters for testing

* add docs

(cherry picked from commit 1a7d03c)
This was referenced Apr 3, 2024
Merged
Merged
sainoe added a commit that referenced this pull request Apr 3, 2024
@mergify @sainoe
test: Add getters for testing epochs in Gaia (backport #1739) (#1750)
272f32a 
test: Add getters for testing epochs in Gaia (#1739)

* add getter and setters for testing

* add docs

(cherry picked from commit 1a7d03c)

Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
MSalopek added a commit that referenced this pull request Apr 8, 2024
@mergify @sainoe @MSalopek
test: Add getters for testing epochs in Gaia (backport #1739) (#1749)
e6eed7e 
test: Add getters for testing epochs in Gaia (#1739)

* add getter and setters for testing

* add docs

(cherry picked from commit 1a7d03c)

Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
Co-authored-by: MSalopek <matija.salopek994@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-offtermatt p-offtermatt p-offtermatt approved these changes

@insumity insumity Awaiting requested review from insumity

Assignees
No one assigned
Labels
C:CI Assigned automatically by the PR labeler C:Testing Assigned automatically by the PR labeler C:x/consumer Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sainoe @mpoke @insumity @p-offtermatt