Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added query for provider parameters #1605

Merged
merged 1 commit into from
Jan 31, 2024
Merged

feat: Added query for provider parameters #1605

merged 1 commit into from
Jan 31, 2024

Conversation

bermuell
Copy link
Contributor

@bermuell bermuell commented Jan 31, 2024 •
edited
Loading

Description

Closes: #1445

Added query provider params to get current values of all provider parameters

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@bermuell bermuell requested a review from a team as a code owner January 31, 2024 10:29
@bermuell bermuell marked this pull request as draft January 31, 2024 10:29
@github-actions github-actions bot added the C:x/provider Assigned automatically by the PR labeler label Jan 31, 2024
@bermuell bermuell force-pushed the bernd/1445-query_provider_params branch from b20965c to 82bf706 Compare January 31, 2024 10:36
@bermuell bermuell force-pushed the bernd/1445-query_provider_params branch from 82bf706 to ccb2d9d Compare January 31, 2024 10:39
@bermuell bermuell added the S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability label Jan 31, 2024
@bermuell bermuell self-assigned this Jan 31, 2024
@bermuell bermuell marked this pull request as ready for review January 31, 2024 10:51
MSalopek
MSalopek approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this!

Please add backport tags to v3.3 and v4

LGTM

mpoke
mpoke approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @bermuell. LGTM. In general, how can we check that such queries actually work?

@bermuell bermuell added this pull request to the merge queue Jan 31, 2024
Merged via the queue into main with commit f5afcb7 Jan 31, 2024
17 checks passed
@bermuell bermuell deleted the bernd/1445-query_provider_params branch January 31, 2024 13:07
mergify bot pushed a commit that referenced this pull request Jan 31, 2024
@bermuell @mergify
feat: Added query for provider parameters (#1605)
fa44692 
Added query for provider parameters

(cherry picked from commit f5afcb7)

# Conflicts:
#	x/ccv/provider/types/query.pb.go
@mergify mergify bot mentioned this pull request Jan 31, 2024
Merged
mergify bot pushed a commit that referenced this pull request Jan 31, 2024
@bermuell @mergify
feat: Added query for provider parameters (#1605)
4c03631 
Added query for provider parameters

(cherry picked from commit f5afcb7)
@mergify mergify bot mentioned this pull request Jan 31, 2024
Merged
@p-offtermatt
Copy link
Contributor

Nice work @bermuell. LGTM. In general, how can we check that such queries actually work?

My guess is, only in the e2e tests

bermuell added a commit that referenced this pull request Jan 31, 2024
@mergify @bermuell
feat: Added query for provider parameters (backport #1605) (#1613)
20b7cd0 
feat: Added query for provider parameters (#1605)

Added query for provider parameters

(cherry picked from commit f5afcb7)

Co-authored-by: bernd-m <43466467+bermuell@users.noreply.github.com>
mpoke pushed a commit that referenced this pull request Jan 31, 2024
@mergify @bermuell
feat: Added query for provider parameters (backport #1605) (#1612)
50b28ff 
* feat: Added query for provider parameters (#1605)

Added query for provider parameters

(cherry picked from commit f5afcb7)

# Conflicts:
#	x/ccv/provider/types/query.pb.go

* Updated proto-gen files

* fix gofumped warning

* Fix broken md-link

---------

Co-authored-by: bernd-m <43466467+bermuell@users.noreply.github.com>
Co-authored-by: Bernd Mueller <bernd@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpoke mpoke mpoke approved these changes

@MSalopek MSalopek MSalopek approved these changes

Assignees

@bermuell bermuell

Labels
C:x/provider Assigned automatically by the PR labeler S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add provider params query to CLI
4 participants
@bermuell @p-offtermatt @mpoke @MSalopek