test: add partial-set-security E2E tests (#1737)

* init commit

* fix traces

* Add PSS to default tests

* Update tests/e2e/steps_partial_set_security.go

Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>

* Update tests/e2e/steps_partial_set_security.go

Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>

---------

Co-authored-by: Philip Offtermatt <p.offtermatt@gmail.com>
Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>

tests/e2e/actions.go

@@ -253,6 +253,7 @@ type SubmitConsumerAdditionProposalAction struct {
 	SpawnTime           uint
 	InitialHeight       clienttypes.Height
 	DistributionChannel string
+	TopN                uint32
 }
 
 func (tr TestConfig) submitConsumerAdditionProposal(
@@ -278,7 +279,7 @@ func (tr TestConfig) submitConsumerAdditionProposal(
 		UnbondingPeriod:                   params.UnbondingPeriod,
 		Deposit:                           fmt.Sprint(action.Deposit) + `stake`,
 		DistributionTransmissionChannel:   action.DistributionChannel,
-		TopN:                              100,
+		TopN:                              action.TopN,
 	}
 
 	bz, err := json.Marshal(prop)
@@ -292,9 +293,14 @@ func (tr TestConfig) submitConsumerAdditionProposal(
 	}
 
 	//#nosec G204 -- bypass unsafe quoting warning (no production code)
-	bz, err = target.ExecCommand(
+	cmd := target.ExecCommand(
 		"/bin/bash", "-c", fmt.Sprintf(`echo '%s' > %s`, jsonStr, "/temp-proposal.json"),
-	).CombinedOutput()
+	)
+	bz, err = cmd.CombinedOutput()
+
+	if verbose {
+		log.Println("submitConsumerAdditionProposal cmd: ", cmd.String())
+	}
 
 	if err != nil {
 		log.Fatal(err, "\n", string(bz))
@@ -2292,6 +2298,98 @@ func (tc TestConfig) startConsumerEvidenceDetector(
 	tc.waitBlocks("provi", 10, 2*time.Minute)
 }
 
+type OptInAction struct {
+	Chain     ChainID
+	Validator ValidatorID
+}
+
+func (tr TestConfig) optIn(action OptInAction, target ExecutionTarget, verbose bool) {
+	// Note: to get error response reported back from this command '--gas auto' needs to be set.
+	gas := "auto"
+	// Unfortunately, --gas auto does not work with CometMock. so when using CometMock, just use --gas 9000000 then
+	if tr.useCometmock {
+		gas = "9000000"
+	}
+
+	// Use: "opt-in [consumer-chain-id] [consumer-pubkey]",
+	optIn := fmt.Sprintf(
+		`%s tx provider opt-in %s --from validator%s --chain-id %s --home %s --node %s --gas %s --keyring-backend test -y -o json`,
+		tr.chainConfigs[ChainID("provi")].BinaryName,
+		string(tr.chainConfigs[action.Chain].ChainId),
+		action.Validator,
+		tr.chainConfigs[ChainID("provi")].ChainId,
+		tr.getValidatorHome(ChainID("provi"), action.Validator),
+		tr.getValidatorNode(ChainID("provi"), action.Validator),
+		gas,
+	)
+
+	cmd := target.ExecCommand(
+		"/bin/bash", "-c",
+		optIn,
+	)
+
+	if verbose {
+		fmt.Println("optIn cmd:", cmd.String())
+	}
+
+	bz, err := cmd.CombinedOutput()
+	_, _ = bz, err
+	if !tr.useCometmock { // error report only works with --gas auto, which does not work with CometMock, so ignore
+		if verbose {
+			fmt.Printf("got expected error during opt in | err: %s | output: %s \n", err, string(bz))
+		}
+	}
+
+	// wait for inclusion in a block -> '--broadcast-mode block' is deprecated
+	tr.waitBlocks(ChainID("provi"), 2, 30*time.Second)
+}
+
+type OptOutAction struct {
+	Chain     ChainID
+	Validator ValidatorID
+}
+
+func (tr TestConfig) optOut(action OptOutAction, target ExecutionTarget, verbose bool) {
+	// Note: to get error response reported back from this command '--gas auto' needs to be set.
+	gas := "auto"
+	// Unfortunately, --gas auto does not work with CometMock. so when using CometMock, just use --gas 9000000 then
+	if tr.useCometmock {
+		gas = "9000000"
+	}
+
+	// Use: "opt-out [consumer-chain-id]",
+	optIn := fmt.Sprintf(
+		`%s tx provider opt-out %s --from validator%s --chain-id %s --home %s --node %s --gas %s --keyring-backend test -y -o json`,
+		tr.chainConfigs[ChainID("provi")].BinaryName,
+		string(tr.chainConfigs[action.Chain].ChainId),
+		action.Validator,
+		tr.chainConfigs[ChainID("provi")].ChainId,
+		tr.getValidatorHome(ChainID("provi"), action.Validator),
+		tr.getValidatorNode(ChainID("provi"), action.Validator),
+		gas,
+	)
+
+	cmd := target.ExecCommand(
+		"/bin/bash", "-c",
+		optIn,
+	)
+
+	if verbose {
+		fmt.Println("optOut cmd:", cmd.String())
+	}
+
+	bz, err := cmd.CombinedOutput()
+	_, _ = bz, err
+	if !tr.useCometmock { // error report only works with --gas auto, which does not work with CometMock, so ignore
+		if verbose {
+			fmt.Printf("got expected error during opt out | err: %s | output: %s \n", err, string(bz))
+		}
+	}
+
+	// wait for inclusion in a block -> '--broadcast-mode block' is deprecated
+	tr.waitBlocks(ChainID("provi"), 2, 30*time.Second)
+}
+
 // WaitTime waits for the given duration.
 // To make sure that the new timestamp is visible on-chain, it also waits until at least one block has been
 // produced on each chain after waiting.

tests/e2e/main.go

@@ -156,6 +156,18 @@ var stepChoices = map[string]StepChoice{
 		description: `Minimal set of test steps to perform compatibility tests`,
 		testConfig:  CompatibilityTestCfg,
 	},
+	"partial-set-security-opt-in": {
+		name:        "partial-set-security-opt-in",
+		steps:       stepsOptInChain(),
+		description: "test partial set security for an Opt-In chain",
+		testConfig:  DefaultTestCfg,
+	},
+	"partial-set-security-top-n": {
+		name:        "partial-set-security-top-n",
+		steps:       stepsTopNChain(),
+		description: "test partial set security for a Top-N chain",
+		testConfig:  DefaultTestCfg,
+	},
 }
 
 func getTestCaseUsageString() string {
@@ -241,7 +253,7 @@ func getTestCases(selectedPredefinedTests, selectedTestFiles TestSet, providerVe
 			"changeover", "happy-path",
 			"democracy-reward", "democracy",
 			"slash-throttle", "consumer-double-sign", "consumer-misbehaviour",
-			"consumer-double-downtime",
+			"consumer-double-downtime", "partial-set-security-opt-in", "partial-set-security-top-n",
 		}
 		if includeMultiConsumer != nil && *includeMultiConsumer {
 			selectedPredefinedTests = append(selectedPredefinedTests, "multiconsumer")

tests/e2e/steps_compatibility.go

@@ -41,6 +41,7 @@ func compstepsStartConsumerChain(consumerName string, proposalIndex, chainIndex
 				ConsumerChain: ChainID(consumerName),
 				SpawnTime:     0,
 				InitialHeight: clienttypes.Height{RevisionNumber: 0, RevisionHeight: 1},
+				TopN:          100,
 			},
 			State: State{
 				ChainID("provi"): ChainState{

tests/e2e/steps_consumer_misbehaviour.go

@@ -36,6 +36,7 @@ func stepsStartChainsWithSoftOptOut(consumerName string) []Step {
 				ConsumerChain: ChainID(consumerName),
 				SpawnTime:     0,
 				InitialHeight: clienttypes.Height{RevisionNumber: 0, RevisionHeight: 1},
+				TopN:          100,
 			},
 			State: State{
 				ChainID("provi"): ChainState{