Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client spec for NEAR protocol (ICS 012) #915

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

riversyang
Copy link

Octopus Network defines a new client spec for NEAR protocol. We pick ICS 012 as the number for this spec.

The minimal implementation of verification algorithm and a sample application for testing is here.

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much, @riversyang, for writing this spec, and sorry for the late review.

I have left a bunch of comments, many of them are for consistency with the other specs. Le me know what you think!

spec/client/ics-012-near-client/README.md Outdated Show resolved Hide resolved
spec/client/ics-012-near-client/README.md Outdated Show resolved Hide resolved
spec/client/ics-012-near-client/README.md Outdated Show resolved Hide resolved
spec/client/ics-012-near-client/README.md Outdated Show resolved Hide resolved
spec/client/ics-012-near-client/README.md Outdated Show resolved Hide resolved
spec/client/ics-012-near-client/README.md Outdated Show resolved Hide resolved
spec/client/ics-012-near-client/README.md Outdated Show resolved Hide resolved
spec/client/ics-012-near-client/README.md Outdated Show resolved Hide resolved
spec/client/ics-012-near-client/README.md Outdated Show resolved Hide resolved
spec/client/ics-012-near-client/README.md Outdated Show resolved Hide resolved
@riversyang
Copy link
Author

Thanks very much, @riversyang, for writing this spec, and sorry for the late review.

I have left a bunch of comments, many of them are for consistency with the other specs. Le me know what you think!

Hi @crodriguezvega, many thanks for the detailed review! I have done a commit to update the doc. When you are available, please check again. Thank you!

@crodriguezvega
Copy link
Contributor

Thank you for addressing all my comments, @riversyang. I just left one follow up comment here. And apologies again for the late reply.

I have also a question: are you planning to work also in the implementation of this light client? And if yes, in what language?

@riversyang
Copy link
Author

Thank you for addressing all my comments, @riversyang. I just left one follow up comment here. And apologies again for the late reply.

I have also a question: are you planning to work also in the implementation of this light client? And if yes, in what language?

Yes, Octopus Network do have a plan to implement a fully functional ICS-012 client with Rust, which can be integrated in ibc-rs. But the schedule has not been decided yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants