Streamline Msg trait and rename to ToProto #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #995 +/- ##
==========================================
+ Coverage 70.63% 70.86% +0.22%
==========================================
Files 178 178
Lines 17976 17918 -58
==========================================
Hits 12698 12698
+ Misses 5278 5220 -58 ☔ View full report in Codecov by Sentry. |
Farhad-Shabani
approved these changes
Nov 30, 2023
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
* Remove Msg::get_sign_bytes method * Update bounds on Msg trait * Rename Msg trait to ToProto * Import prost::Name in ToProto::to_any fn * Change `impl Msg` implementations * Define blanket implementation of ToProto * Rename msg.rs to proto.rs * Remove `impl ToProto` blocks * chore: add unclog --------- Co-authored-by: Farhad Shabani <farhad.shabani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #993
Description
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.