chore: fix dependency resolution because of dep: syntax in serde feature
#988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I’m not entirely sure if it’s no_std specifically that causes the
issue, but if ibc-apps-transfer is build without std feature but with
serde feature it enables serde_json/std feature while serde_json
dependency isn’t enabled. This seems to confuse Cargo which thinks
serde_json is supposed to be a feature. This all leads to a failure
in dependency resolution:
error: failed to select a version for `ibc-app-transfer`.
... required by package `ibc-apps v0.48.0`
... which satisfies dependency `ibc-apps = "^0.48.0"` (locked to 0.48.0) of package `ibc v0.48.0`
... which satisfies dependency `ibc = "^0.48.0"` (locked to 0.48.0) of package `ibc-testkit v0.48.0`
... which satisfies dependency `ibc-testkit = "^0.48.0"` (locked to 0.48.0) of package …
versions that meet the requirements `^0.48.0` (locked to 0.48.0) are: 0.48.0
the package `ibc-apps` depends on `ibc-app-transfer`, with features: `serde_json` but `ibc-app-transfer` does not have these features.
It has an optional dependency with that name, but that dependency uses the "dep:" syntax in the features table, so it does not have an implicit feature with that name.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #988 +/- ##
=======================================
Coverage 70.30% 70.30%
=======================================
Files 178 178
Lines 17692 17692
=======================================
Hits 12439 12439
Misses 5253 5253 ☔ View full report in Codecov by Sentry. |
Farhad-Shabani
requested changes
Nov 26, 2023
Farhad-Shabani
changed the title
dep: syntax in serde feature
Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com> Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Farhad-Shabani
approved these changes
Nov 26, 2023
Merged
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
…feature (#988) * chore: fix no_std builds * Update .changelog/unreleased/bug-fixes/987-serde-json-feature.md Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com> Signed-off-by: Michal Nazarewicz <mina86@mina86.com> * review --------- Signed-off-by: Michal Nazarewicz <mina86@mina86.com> Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m not entirely sure if it’s no_std specifically that causes the
issue, but if ibc-apps-transfer is build without std feature but with
serde feature it enables serde_json/std feature while serde_json
dependency isn’t enabled. This seems to confuse Cargo which thinks
serde_json is supposed to be a feature. This all leads to a failure
in dependency resolution:
Closes: #987
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.