-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: restructure ibc
crate
#975
Merged
Merged
Commits on Nov 17, 2023
-
feat: migrate
applications
module under theibc
crate into `ibc-a……pps` (#967) * feat: restructure and split off applications codebase into ibc-apps dir * imp: rename transfer dir to ics20_transfer * feat: add ibc-apps crate * fix: remove redundant dep + fix cargo doc * docs: add README and descriptions * docs: update main README page * nit: docstrings * nit: docstrings * imp: rename folder to ics20-transfer * chore: move serializers into ics20-transfer/types * fix: apply reviewer comments * imp: add docstring for cosmos_adr028_escrow_address * fix: add missing features + use workspace deps for ibc crates * imp: place re-exports under mod * nit: apply suggestions from code review Co-authored-by: Sean Chen <seanchen11235@gmail.com> Signed-off-by: Farhad Shabani <Farhad.Shabani@gmail.com> * fix: cargo fmt --------- Signed-off-by: Farhad Shabani <Farhad.Shabani@gmail.com> Co-authored-by: Sean Chen <seanchen11235@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 68b4ca6 - Browse repository at this point
Copy the full SHA 68b4ca6View commit details
Commits on Nov 21, 2023
-
docs: ADR-008 to restructure the
ibc
crate (#966)* docs: write ADR for ibc crate restructure * fix: mistaken adr007 file naming * chore: markdown adjustment * fix: apply suggestions from code review Co-authored-by: Sean Chen <seanchen11235@gmail.com> Signed-off-by: Farhad Shabani <Farhad.Shabani@gmail.com> * docs: explanation for *-types interaction with ibc-proto --------- Signed-off-by: Farhad Shabani <Farhad.Shabani@gmail.com> Co-authored-by: Sean Chen <seanchen11235@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 55038aa - Browse repository at this point
Copy the full SHA 55038aaView commit details -
feat: migrate
core
,clients
modules intoibc-core
, `ibc-clients……` crates (#969) * feat: migrate `core` module under the `ibc` crate into `ibc-core` feat: migrate `core` module under the `ibc` crate into `ibc-core` feat: migrate `applications` module under the `ibc` crate into `ibc-apps` (#967) * feat: restructure and split off applications codebase into ibc-apps dir * imp: rename transfer dir to ics20_transfer * feat: add ibc-apps crate * fix: remove redundant dep + fix cargo doc * docs: add README and descriptions * docs: update main README page * nit: docstrings * nit: docstrings * imp: rename folder to ics20-transfer * chore: move serializers into ics20-transfer/types * fix: apply reviewer comments * imp: add docstring for cosmos_adr028_escrow_address * fix: add missing features + use workspace deps for ibc crates * imp: place re-exports under mod * nit: apply suggestions from code review Co-authored-by: Sean Chen <seanchen11235@gmail.com> Signed-off-by: Farhad Shabani <Farhad.Shabani@gmail.com> * fix: cargo fmt --------- Signed-off-by: Farhad Shabani <Farhad.Shabani@gmail.com> Co-authored-by: Sean Chen <seanchen11235@gmail.com> feat: restructure and split off applications codebase into ibc-apps dir refactor: nits from nightly clippy (#962) * use enum tuple variants directly * use first() over get(0) * use infallible conversion * rm redundant export * cargo fmt ci: spell check on GitHub workflows (#964) * typos github action * cutom config for typos * fix spelling to counterparty * fix spelling to transfer imp: rename transfer dir to ics20_transfer feat: add ibc-apps crate fix: remove redundant dep + fix cargo doc docs: add README and descriptions docs: update main README page nit: docstrings nit: docstrings imp: rename folder to ics20-transfer chore: move serializers into ics20-transfer/types fix: apply reviewer comments imp: add docstring for cosmos_adr028_escrow_address fix: add missing features + use workspace deps for ibc crates imp: place re-exports under mod feat: ibc core codebase overhaul (part-1) feat: ibc core codebase overhaul (part-2) chore: comment out ibc-query & ibc-testkit fix: add missing features nit * fix: re-export ibc_apps in the ibc crate * chore: adjust features + add description for crates * fix: CI catches * fix: no_std * imp: define ics25-handler + move tendermint-specific impls into ibc-core-host-tendermint * fix: cargo doc * docs: add and edit READMEs * fix: cargo hack catches * fix: cargo udeps catches * chore: ajdust README tables * docs: further README adjustments * fix: typo * chore: another review of comments & READMEs * imp: move Any and Protobuf to ibc-primitives * fix: missing std features * Split out ibc-clients crate (#971) * Migrate crates/ibc-clients * Fix dependencies in types directory * Fix dependencies in ibc-clients crate * Delete ibc/ics07_tendermint directory * Resolve dependencies in ibc crate * Resolve dependencies in ibc-clients crate * Wrap ClientState type in a newtype wrapper * Address all compilation errors * Migrate crates/ibc-clients * Fix dependencies in types directory * Fix dependencies in ibc-clients crate * Delete ibc/ics07_tendermint directory * Resolve dependencies in ibc crate * Resolve dependencies in ibc-clients crate * Wrap ClientState type in a newtype wrapper * Address all compilation errors * Add default feature `std` for ibc-clients crate * Change cfg derivation * Fixing import paths * Fix import paths for ibc-client-tendermint crate * Fix merge conflicts * Fix merge conflicts * Fix merge conflicts * Fix remaining compilation errors in ics07-tendermint crate * chore: adjust import paths, features and READMEs * fix: CI catches * fix: add serde dep for ibc-client-tendermint * fix: serde_tests * imp: rename ClientState to ClientStateWrapper --------- Co-authored-by: Farhad Shabani <farhad.shabani@gmail.com> * docs: improve crates descriptions * fix: apply reviewer comments * Delete some unused modules and add some documentation * Add TODO to use u64::dev_ceil * Formatting of ibc-primitives README * fix: ibc-primitives serde feature --------- Co-authored-by: Sean Chen <seanchen11235@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3cc9753 - Browse repository at this point
Copy the full SHA 3cc9753View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8cf526 - Browse repository at this point
Copy the full SHA d8cf526View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8307b7c - Browse repository at this point
Copy the full SHA 8307b7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 38335e6 - Browse repository at this point
Copy the full SHA 38335e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 42d4c2e - Browse repository at this point
Copy the full SHA 42d4c2eView commit details
Commits on Nov 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 90c5633 - Browse repository at this point
Copy the full SHA 90c5633View commit details -
Configuration menu - View commit details
-
Copy full SHA for db42ee2 - Browse repository at this point
Copy the full SHA db42ee2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab83bfb - Browse repository at this point
Copy the full SHA ab83bfbView commit details -
fix: apply suggestions from code review
Co-authored-by: Sean Chen <seanchen11235@gmail.com> Signed-off-by: Farhad Shabani <Farhad.Shabani@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 19b945c - Browse repository at this point
Copy the full SHA 19b945cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fdf8ba1 - Browse repository at this point
Copy the full SHA fdf8ba1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8e22b7 - Browse repository at this point
Copy the full SHA a8e22b7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.