Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code clean-up remained from v0.37.0 #622

Merged
merged 4 commits into from
Apr 14, 2023
Merged

Code clean-up remained from v0.37.0 #622

merged 4 commits into from
Apr 14, 2023

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Apr 14, 2023

Closes: #XXX

Caught my eye while reviewing different message types for adding missing checks.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review April 14, 2023 14:28
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (014fec6) 73.19% compared to head (959ad12) 73.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
- Coverage   73.19%   73.19%   -0.01%     
==========================================
  Files         125      125              
  Lines       15660    15659       -1     
==========================================
- Hits        11463    11462       -1     
  Misses       4197     4197              
Impacted Files Coverage Δ
crates/ibc/src/clients/ics07_tendermint/error.rs 19.04% <ø> (ø)
crates/ibc/src/clients/ics07_tendermint/header.rs 84.96% <100.00%> (ø)
...ibc/src/core/ics02_client/handler/update_client.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Philippe Laferrière <plafer@protonmail.com>
@plafer plafer merged commit 320df85 into main Apr 14, 2023
@plafer plafer deleted the farhad/v0.37.0-cleanup branch April 14, 2023 18:46
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
* Code clean-up remained from v0.37.0

* Revise pr number

* Adapt changelog

* Update .changelog/unreleased/breaking-changes/622-v0.37.0-cleanup.md

Signed-off-by: Philippe Laferrière <plafer@protonmail.com>

---------

Signed-off-by: Philippe Laferrière <plafer@protonmail.com>
Co-authored-by: Philippe Laferrière <plafer@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants