Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with PacketReceiptNotFound error returned by get_packet_receipt method #410

Merged
merged 5 commits into from
Feb 9, 2023
Merged

Fix issue with PacketReceiptNotFound error returned by get_packet_receipt method #410

merged 5 commits into from
Feb 9, 2023

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Feb 9, 2023 •
edited
Loading

Closes: #409

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani self-assigned this Feb 9, 2023
@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review February 9, 2023 19:54
@codecov
Copy link

codecov bot commented Feb 9, 2023 •
edited
Loading

Codecov Report

Base: 55.68% // Head: 55.63% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (9e7524e) compared to base (6f482c1).
Patch coverage: 18.18% of modified lines in pull request are covered.

❗ Current head 9e7524e differs from pull request most recent head 2386e38. Consider uploading reports for the commit 2386e38 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
- Coverage   55.68%   55.63%   -0.06%     
==========================================
  Files         122      122              
  Lines       17068    17078      +10     
==========================================
- Hits         9505     9501       -4     
- Misses       7563     7577      +14
Impacted Files Coverage Δ
.../ibc/src/core/ics04_channel/handler/recv_packet.rs 40.07% <18.18%> (-2.01%) ⬇️
crates/ibc/src/timestamp.rs 47.44% <0.00%> (-0.71%) ⬇️
crates/ibc/src/core/ics03_connection/connection.rs 29.74% <0.00%> (-0.19%) ⬇️
crates/ibc/src/core/handler.rs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

plafer
plafer approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@Farhad-Shabani Farhad-Shabani merged commit 2722fba into main Feb 9, 2023
@Farhad-Shabani Farhad-Shabani deleted the farhad/fix-receipt-not-found branch February 9, 2023 21:12
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
@Farhad-Shabani
Fix issue with PacketReceiptNotFound error returned by `get_packet_…
46fd782 
…receipt` method (#410)

* Accept `PacketReceiptNotFound` error variant returned by `get_packet_receipt` method

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plafer plafer plafer approved these changes

Assignees

@Farhad-Shabani Farhad-Shabani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accepting PacketReceiptNotFound error returned by get_packet_receipt (under val_exec_ctx feature)
2 participants
@Farhad-Shabani @plafer