Implement ICS-26 router for RecvPacket in {Validation,Execution}Context
#377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plafer
changed the title
{Validation,Execution}Context
Codecov ReportBase: 60.42% // Head: 58.76% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
==========================================
- Coverage 60.42% 58.76% -1.67%
==========================================
Files 124 124
Lines 15665 16116 +451
==========================================
+ Hits 9466 9470 +4
- Misses 6199 6646 +447
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This was referenced Jan 26, 2023
Closed
plafer
changed the title
{Validation,Execution}ContextonRecvPacket in {Validation,Execution}Context
plafer
changed the title
onRecvPacket in {Validation,Execution}ContextRecvPacket in {Validation,Execution}Context
Farhad-Shabani
approved these changes
Jan 31, 2023
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
…ntext` (#377) * packet validation scaffoldinig * recv_packet validation * remove todo * recv_packet_validate() * execute scaffolding * Module::on_recv_packet_execute * token transfer on_recv_packet (with a FIXME) * recv_packet_execute * refactor expression for readability * add comment * ack cannot be empty * token transfer ack * clippy * fix token transfer recv_packet * typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards: #322
Changed the scope of this PR to include only
recvPacket, since it turned out to have many subtleties to get right.Description
As with the other PRs, this one focuses on correctness. The more we get closer to being done with #322, the more it becomes obvious that we need a refactor. Let's hold off until we're completely done though; it will be easier to make a big refactor after #279.
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.