Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update issue templates and CONTRIBUTING.md #345

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Update issue templates and CONTRIBUTING.md #345

merged 3 commits into from
Jan 12, 2023

Conversation

Farhad-Shabani
Copy link
Member

Closes: #344

PR author checklist:

  • Linked to GitHub issue.
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.

@Farhad-Shabani Farhad-Shabani force-pushed the farhad/update-templates-and-contributing branch from c131705 to a8647c5 Compare January 11, 2023 03:50
plafer
plafer suggested changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just now thinking: I think it would be best to not ask people who open issues to label them; we should instead do it ourselves. After all, the tags are mainly for us, and we'll know our tagging system better than, say, first time issue openers. WDYT?

.github/ISSUE_TEMPLATE/bug-report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug-report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug-report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature-request.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature-request.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature-request.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/process-improvement.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated
- (WHY) The purpose or objective of this issue with Objective-level "O" labels like `O: security`, `O: new-feature`, etc.
- (WHICH) The part of the system this issue relates to using:
- External-level "E" labels if the issue fall outside the current scope of the system and is related to external dependencies or projects like `E: non-cosmos`, `E: no-std` etc.
- or "Internal-level "I" labels for anything related to the current scope of the product like `I: logic`, `I: documentation`, etc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside: isn't I: logic redundant with A: bug?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By logic, I meant changes that impact the overall logic (or main design streams). Bugs can also have such effects, but some improvements or features can as well

CONTRIBUTING.md Outdated Show resolved Hide resolved
@Farhad-Shabani
Copy link
Member Author

Thank you for the points 🙏

plafer
plafer approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few edits; please make sure you agree with them. If you do, please merge it all 😄

@Farhad-Shabani Farhad-Shabani merged commit 7a7dad7 into main Jan 12, 2023
@Farhad-Shabani Farhad-Shabani deleted the farhad/update-templates-and-contributing branch January 12, 2023 15:53
@Farhad-Shabani
Copy link
Member Author

Made a few edits; please make sure you agree with them. If you do, please merge it all 😄
🙏

plafer added a commit that referenced this pull request Jan 12, 2023
@Farhad-Shabani @plafer
Update issue templates and CONTRIBUTING.md (#345)
6e13929 
* Update issue templates and CONTRIBUTING.md

* Reflect review input

* few edits

Co-authored-by: Philippe Laferriere <plafer@protonmail.com>
hu55a1n1 added a commit that referenced this pull request Jan 12, 2023
@hu55a1n1 @DaviRain-Su
@plafer @Farhad-Shabani
Add serde feature (#331)
ef52941 
* Add serde feature

* Fix clippy warnings

* Feature gate serde imports

* Fix for `ErasedSerialize`

* Fix unused imports

* Fix CI

* cargo fmt

* Add serde feature to no-std-check's ibc dep

* Document ErasedSerialize re-export

* Move TimeoutHeight serde into it's own module

* Move ClientState serde tests into it's own module

* Fix typo

* Apply suggestions from code review

Co-authored-by: Philippe Laferrière <plafer@protonmail.com>
Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com>

* Update issue templates and CONTRIBUTING.md (#345)

* Update issue templates and CONTRIBUTING.md

* Reflect review input

* few edits

Co-authored-by: Philippe Laferriere <plafer@protonmail.com>

* make transfer application serde-dependent

Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: Davirain <davirain.yin@gmail.com>
Co-authored-by: Philippe Laferrière <plafer@protonmail.com>
Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com>
plafer added a commit that referenced this pull request Jan 12, 2023
@hu55a1n1 @DaviRain-Su
@plafer @Farhad-Shabani
Add serde feature (#331)
ea797d0 
* Add serde feature

* Fix clippy warnings

* Feature gate serde imports

* Fix for `ErasedSerialize`

* Fix unused imports

* Fix CI

* cargo fmt

* Add serde feature to no-std-check's ibc dep

* Document ErasedSerialize re-export

* Move TimeoutHeight serde into it's own module

* Move ClientState serde tests into it's own module

* Fix typo

* Apply suggestions from code review

Co-authored-by: Philippe Laferrière <plafer@protonmail.com>
Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com>

* Update issue templates and CONTRIBUTING.md (#345)

* Update issue templates and CONTRIBUTING.md

* Reflect review input

* few edits

Co-authored-by: Philippe Laferriere <plafer@protonmail.com>

* make transfer application serde-dependent

Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: Davirain <davirain.yin@gmail.com>
Co-authored-by: Philippe Laferrière <plafer@protonmail.com>
Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com>
plafer added a commit that referenced this pull request Jan 12, 2023
@plafer @hu55a1n1
@DaviRain-Su @Farhad-Shabani
Release v0.26.0 (#348)
605e7b5 
* unclog release

* bump version

* Add serde feature (#331)

* Add serde feature

* Fix clippy warnings

* Feature gate serde imports

* Fix for `ErasedSerialize`

* Fix unused imports

* Fix CI

* cargo fmt

* Add serde feature to no-std-check's ibc dep

* Document ErasedSerialize re-export

* Move TimeoutHeight serde into it's own module

* Move ClientState serde tests into it's own module

* Fix typo

* Apply suggestions from code review

Co-authored-by: Philippe Laferrière <plafer@protonmail.com>
Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com>

* Update issue templates and CONTRIBUTING.md (#345)

* Update issue templates and CONTRIBUTING.md

* Reflect review input

* few edits

Co-authored-by: Philippe Laferriere <plafer@protonmail.com>

* make transfer application serde-dependent

Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: Davirain <davirain.yin@gmail.com>
Co-authored-by: Philippe Laferrière <plafer@protonmail.com>
Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com>

* add serde changelog from #331

Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: Davirain <davirain.yin@gmail.com>
Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com>
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
@Farhad-Shabani @plafer
Update issue templates and CONTRIBUTING.md (#345)
62fbd14 
* Update issue templates and CONTRIBUTING.md

* Reflect review input

* few edits

Co-authored-by: Philippe Laferriere <plafer@protonmail.com>
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
@hu55a1n1 @DaviRain-Su
@plafer @Farhad-Shabani
Add serde feature (#331)
545f8c7 
* Add serde feature

* Fix clippy warnings

* Feature gate serde imports

* Fix for `ErasedSerialize`

* Fix unused imports

* Fix CI

* cargo fmt

* Add serde feature to no-std-check's ibc dep

* Document ErasedSerialize re-export

* Move TimeoutHeight serde into it's own module

* Move ClientState serde tests into it's own module

* Fix typo

* Apply suggestions from code review

Co-authored-by: Philippe Laferrière <plafer@protonmail.com>
Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com>

* Update issue templates and CONTRIBUTING.md (#345)

* Update issue templates and CONTRIBUTING.md

* Reflect review input

* few edits

Co-authored-by: Philippe Laferriere <plafer@protonmail.com>

* make transfer application serde-dependent

Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: Davirain <davirain.yin@gmail.com>
Co-authored-by: Philippe Laferrière <plafer@protonmail.com>
Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com>
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
@plafer @hu55a1n1
@DaviRain-Su @Farhad-Shabani
Release v0.26.0 (#348)
c63cbcd 
* unclog release

* bump version

* Add serde feature (#331)

* Add serde feature

* Fix clippy warnings

* Feature gate serde imports

* Fix for `ErasedSerialize`

* Fix unused imports

* Fix CI

* cargo fmt

* Add serde feature to no-std-check's ibc dep

* Document ErasedSerialize re-export

* Move TimeoutHeight serde into it's own module

* Move ClientState serde tests into it's own module

* Fix typo

* Apply suggestions from code review

Co-authored-by: Philippe Laferrière <plafer@protonmail.com>
Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com>

* Update issue templates and CONTRIBUTING.md (#345)

* Update issue templates and CONTRIBUTING.md

* Reflect review input

* few edits

Co-authored-by: Philippe Laferriere <plafer@protonmail.com>

* make transfer application serde-dependent

Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: Davirain <davirain.yin@gmail.com>
Co-authored-by: Philippe Laferrière <plafer@protonmail.com>
Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com>

* add serde changelog from #331

Signed-off-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: Davirain <davirain.yin@gmail.com>
Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plafer plafer plafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify ISSUE_TEMPLATES with adding a guide for labels to CONTRIBUTING.md
2 participants
@Farhad-Shabani @plafer