Add parity-scale-codec and borsh for IbcEvent #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 63.80% // Head: 62.44% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
==========================================
- Coverage 63.80% 62.44% -1.37%
==========================================
Files 124 124
Lines 13771 14072 +301
==========================================
Hits 8787 8787
- Misses 4984 5285 +301
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
plafer
reviewed
Jan 4, 2023
Cargo.toml
Outdated
| @@ -9,3 +9,6 @@ members = [ | |||
| exclude = [ | |||
| "ci/no-std-check", | |||
| ] | |||
|
|
|||
| [patch.crates-io] | |||
| ibc-proto = { git = "https://github.com/octopus-network/ibc-proto-rs.git", branch = "add-codec-borsh-for-any" } | |||
There was a problem hiding this comment.
How about we leave this PR in draft until this patch is removed?
|
blocked on cosmos/ibc-proto-rs#51 |
plafer
added
A: blocked
plafer
suggested changes
Jan 10, 2023
ci/no-std-check/Cargo.toml
Outdated
| @@ -6,7 +6,7 @@ resolver = "2" | |||
|
|
|||
| [dependencies] | |||
| ibc = { path = "../../crates/ibc", default-features = false } | |||
| ibc-proto = { version = "0.24.0", default-features = false } | |||
| ibc-proto = { version = "0.24.0", default-features = false, features = ["parity-scale-codec", "borsh"]} | |||
There was a problem hiding this comment.
0.24.1 is now released with the required change; can you update it here and remove the [patch.crates-io] section?
| @@ -10,6 +10,7 @@ use crate::{ | |||
| timestamp::Timestamp, | |||
| }; | |||
| use derive_more::From; | |||
| use serde_derive::{Deserialize, Serialize}; | |||
There was a problem hiding this comment.
Can you remove all new serde_derive imports? This will cause conflicts with #331
There was a problem hiding this comment.
I added a comment at all the other ones so that we don't forget any
| @@ -3,6 +3,7 @@ use crate::prelude::*; | |||
| use derive_more::{From, Into}; | |||
| use ibc_proto::ibc::core::channel::v1::MsgAcknowledgement as RawMsgAcknowledgement; | |||
| use ibc_proto::protobuf::Protobuf; | |||
| use serde_derive::{Deserialize, Serialize}; | |||
| @@ -10,6 +10,7 @@ use crate::core::ics02_client::height::Height; | |||
| use crate::core::ics24_host::identifier::ClientId; | |||
| use crate::events::IbcEventType; | |||
| use crate::prelude::*; | |||
| use serde_derive::{Deserialize, Serialize}; | |||
| @@ -3,6 +3,7 @@ | |||
| mod channel_attributes; | |||
| mod packet_attributes; | |||
|
|
|||
| use serde_derive::{Deserialize, Serialize}; | |||
| @@ -1,6 +1,7 @@ | |||
| ///! This module holds all the abci event attributes for IBC events emitted | |||
| ///! during the channel handshake. | |||
| use derive_more::From; | |||
| use serde_derive::{Deserialize, Serialize}; | |||
Signed-off-by: Davirain <davirain.yin@gmail.com>
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* add parity-scale-codec and borsh for IbcEvent * Create 320-add-borsh-and-scale-codec-for-ibcevent.md * Update no-std-check ibc-proto dep * Add patch ibc-proto for no-std-check * Update ibc-proto patch * Update Cargo.toml * Update ibc-proto version and Add serde feature Signed-off-by: Davirain <davirain.yin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #320
Description
You need to merge this PR( cosmos/ibc-proto-rs#48) first before merging the PR.
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.