Add codec borsh feature

[DaviRain-Su]

Closes: #259

Description

---

PR author checklist:

• Added changelog entry, using unclog.
• Added tests.
• Linked to GitHub issue.
• Updated code comments and documentation (e.g., docs/).
• Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

• Reviewed Files changed in the GitHub PR explorer.
• Manually tested (in case integration/unit/mock tests are absent).

[codecov]

Codecov Report

Base: 67.46% // Head: 66.14% // Decreases project coverage by -1.31% ⚠️

Coverage data is based on head (362cb6c) compared to base (edb9d7c).
Patch coverage: 0.40% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
- Coverage   67.46%   66.14%   -1.32%     
==========================================
  Files         125      125              
  Lines       12796    13051     +255     
==========================================
  Hits         8633     8633              
- Misses       4163     4418     +255     

Impacted Files	Coverage Δ
crates/ibc/src/core/ics02_client/client_type.rs	43.75% <0.00%> (-26.25%)	⬇️
crates/ibc/src/core/ics02_client/height.rs	59.81% <0.00%> (-3.56%)	⬇️
...rates/ibc/src/core/ics02_client/trust_threshold.rs	60.34% <0.00%> (-6.97%)	⬇️
crates/ibc/src/core/ics03_connection/connection.rs	29.61% <0.00%> (-9.46%)	⬇️
crates/ibc/src/core/ics03_connection/version.rs	90.25% <0.00%> (-3.66%)	⬇️
crates/ibc/src/core/ics04_channel/channel.rs	54.01% <0.00%> (-5.77%)	⬇️
crates/ibc/src/core/ics04_channel/commitment.rs	21.87% <0.00%> (-13.13%)	⬇️
crates/ibc/src/core/ics04_channel/packet.rs	51.25% <0.00%> (-3.42%)	⬇️
crates/ibc/src/core/ics04_channel/timeout.rs	39.04% <0.00%> (-2.37%)	⬇️
crates/ibc/src/core/ics04_channel/version.rs	64.70% <0.00%> (-13.87%)	⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[plafer]

@DaviRain-Su is this ready to be reviewed? Whenever you're ready, please mark the PR as "ready for review" and I'll review it!

[DaviRain-Su]

@DaviRain-Su is this ready to be reviewed? Whenever you're ready, please mark the PR as "ready for review" and I'll review it!

yet, it can review

[plafer]

Once again, great work here.

This is just a preliminary review, will finish it later!

[plafer]

I notice that a subset of the types were tagged as serializable/deserializable by borsh and parity-scale-codec. What is the reasoning behind the choice of which type should be serializable/deserializable?

[DaviRain-Su]

I notice that a subset of the types were tagged as serializable/deserializable by borsh and parity-scale-codec. What is the reasoning behind the choice of which type should be serializable/deserializable?

In the substrate pallet we use the scale-codec encoding, while using borsh is the next contract we have to use

[plafer]

almost there 😃

[plafer]

Left a few improvements!

[plafer]

A few uses of the derive macros were forgotten, and left a few nits!

[DaviRain-Su]

this is error, I change they suggest but have also error.

error: `Box::new(_)` of default value
    --> crates/ibc/src/mock/context.rs:1882:21
     |
1882 |                     Box::new(MockAck::default()),
     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Box::default()`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_default
note: the lint level is defined here
    --> crates/ibc/src/lib.rs:8:5
     |
8    |     warnings,
     |     ^^^^^^^^
     = note: `#[deny(clippy::box_default)]` implied by `#[deny(warnings)]`

[plafer]

The CI fails because Rust 1.66 was just released. This fixes it:

diff --git a/crates/ibc/src/mock/context.rs b/crates/ibc/src/mock/context.rs
index 05b48096..6ffffae1 100644
--- a/crates/ibc/src/mock/context.rs
+++ b/crates/ibc/src/mock/context.rs
@@ -1879,7 +1879,7 @@ mod tests {
                 _relayer: &Signer,
             ) -> OnRecvPacketAck {
                 OnRecvPacketAck::Successful(
-                    Box::new(MockAck::default()),
+                    Box::<MockAck>::default(),
                     Box::new(|module| {
                         let module = module.downcast_mut::<FooModule>().unwrap();
                         module.counter += 1;

[plafer]

Thank you @DaviRain-Su! I very much appreciate your contributions 😄