Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up ibc-core and ibc-clients error types #1317

Merged
merged 50 commits into from
Aug 23, 2024

Merge branch 'error-handling' of https://github.com/cosmos/ibc-rs int…

474909d
Select commit
Loading
Failed to load commit list.
Merged

Clean up ibc-core and ibc-clients error types #1317

Merge branch 'error-handling' of https://github.com/cosmos/ibc-rs int…
474909d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 22, 2024 in 1s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

Attention: Patch coverage is 58.80000% with 206 lines in your changes missing coverage. Please review.

Please upload report for BASE (error-handling@0d98ebf). Learn more about missing BASE report.

Files Patch % Lines
ibc-core/ics25-handler/types/src/msgs.rs 0.00% 19 Missing ⚠️
ibc-core/ics23-commitment/types/src/merkle.rs 5.26% 18 Missing ⚠️
ibc-clients/ics07-tendermint/types/src/header.rs 60.00% 14 Missing ⚠️
ibc-testkit/src/testapp/ibc/core/core_ctx.rs 62.06% 11 Missing ⚠️
ibc-core/ics02-client/types/src/events.rs 74.35% 10 Missing ⚠️
...ore/ics24-host/cosmos/src/upgrade_proposal/plan.rs 0.00% 9 Missing ⚠️
...core/ics24-host/cosmos/src/validate_self_client.rs 0.00% 9 Missing ⚠️
...clients/ics07-tendermint/types/src/misbehaviour.rs 41.66% 7 Missing ⚠️
ibc-clients/ics08-wasm/types/src/client_state.rs 45.45% 6 Missing ⚠️
...-core/ics04-channel/src/handler/acknowledgement.rs 57.14% 6 Missing ⚠️
... and 37 more
Additional details and impacted files 
@@                Coverage Diff                @@
##             error-handling    #1317   +/-   ##
=================================================
  Coverage                  ?   67.18%           
=================================================
  Files                     ?      227           
  Lines                     ?    23283           
  Branches                  ?        0           
=================================================
  Hits                      ?    15643           
  Misses                    ?     7640           
  Partials                  ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov