Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add missing domain and proto type re-exports #1041

Merged
merged 5 commits into from
Jan 18, 2024
Merged

chore: add missing domain and proto type re-exports #1041

merged 5 commits into from
Jan 18, 2024

Conversation

Farhad-Shabani
Copy link
Member

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review January 18, 2024 06:32
@codecov Codecov
Copy link

codecov bot commented Jan 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d5e8314) 71.45% compared to head (22d6c86) 71.45%.

❗ Current head 22d6c86 differs from pull request most recent head 1590e4b. Consider uploading reports for the commit 1590e4b to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1041   +/-   ##
=======================================
  Coverage   71.45%   71.45%           
=======================================
  Files         187      187           
  Lines       18516    18516           
=======================================
  Hits        13230    13230           
  Misses       5286     5286

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rnbguy
rnbguy approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 👍

Just added a comment about cosmwasm feature of wasm client types.

@Farhad-Shabani Farhad-Shabani merged commit bc3bcca into main Jan 18, 2024
13 checks passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/re-export-missing-types branch January 18, 2024 15:33
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
@Farhad-Shabani @rnbguy
chore: add missing domain and proto type re-exports (#1041)
defd0d2 
* chore: re-export missing types

* nit: cargo fmt

* changelog fmt

* whitespace nits

* fix: introduce missing cosmwasm feature

---------

Co-authored-by: Ranadeep Biswas <mail@rnbguy.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnbguy rnbguy rnbguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
ibc-rs
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Farhad-Shabani @rnbguy