Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectionOpenTry: ValidateSelfClient validation missing #158

Closed
5 tasks
plafer opened this issue Oct 7, 2022 · 2 comments
Closed
5 tasks

ConnectionOpenTry: ValidateSelfClient validation missing #158

plafer opened this issue Oct 7, 2022 · 2 comments
Labels
A: bug Admin: something isn't working

Comments

@plafer
Copy link
Contributor

plafer commented Oct 7, 2022

Summary of Bug

We are currently missing the entire ValidateSelfClient checks (see ibc-go impl as reference).

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@plafer plafer added the A: bug Admin: something isn't working label Oct 7, 2022
@plafer
Copy link
Contributor Author

plafer commented Oct 7, 2022

Blocked on #159.

@plafer
Copy link
Contributor Author

plafer commented Oct 21, 2022

duplicate of #162

@plafer plafer closed this as completed Oct 21, 2022
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
@Farhad-Shabani
feat: enable no_std support for pbjson (cosmos#158)
864b821 
Closes: cosmos#156

Addresses the `no_std` compatibility issue with `serde` feature in `ibc-rs`. This is caused by the recent implementation of ProtoJSON serialization and deserialization [0] for the `ics23` Protobuf definitions using `pbjson`, and then re-exporting the ics23 type [1] in `ibc-proto-rs`. Some of our users by then (starting from IBC-rs v0.41.0) are experiencing compilation errors. [2]

To meet this immediate need [3] and the lack of activity in the `pbjson` crate for months, we have taken the initiative to feature `no_std` support in the `informalsystems-pbjson` crate and have it published.

[0] cosmos/ics23#146
[1] cosmos/ibc-proto-rs#92
[2] cosmos#741
[3] cosmos/ibc-proto-rs#98 (comment)

---

* feat: enable no_std support for pbjson

* fix: get serde feature work with no-std

* deps: use informalsystems-pbjson v0.6.0

* deps: use informalsystems-pbjson v0.6.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: bug Admin: something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@plafer