Check that round-tripped data is equal in tests (#497)

cosmos · Mar 6, 2023 · 3d8c2ef · 3d8c2ef
1 parent 289b6ba
commit 3d8c2ef
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.changelog/unreleased/improvements/497-check-serde-eq.md b/.changelog/unreleased/improvements/497-check-serde-eq.md
@@ -0,0 +1,2 @@
+- In `test_serialization_roundtrip`, check that round-tripped data is equal
+  ([#497](https://github.com/cosmos/ibc-rs/issues/497))
diff --git a/crates/ibc/src/test.rs b/crates/ibc/src/test.rs
@@ -10,7 +10,7 @@ use serde::{de::DeserializeOwned, Serialize};
 #[cfg(feature = "serde")]
 pub fn test_serialization_roundtrip<T>(json_data: &str)
 where
-    T: core::fmt::Debug + Serialize + DeserializeOwned,
+    T: core::fmt::Debug + PartialEq + Serialize + DeserializeOwned,
 {
     let parsed0 = serde_json::from_str::<T>(json_data);
     assert!(parsed0.is_ok());
@@ -22,7 +22,7 @@ where
 
     let parsed1 = serde_json::from_str::<T>(&serialized);
     assert!(parsed1.is_ok());
+    let parsed1 = parsed1.unwrap();
 
-    // TODO - fix PartialEq bound issue in AbciQuery
-    //assert_eq!(parsed0, parsed1);
+    assert_eq!(parsed0, parsed1);
 }