feat: re-export google protos from tendermint_proto
#242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR and sorry for the oversight! |
romac
approved these changes
Sep 25, 2024
|
Perhaps in the future we should consider extracting these wkt protos into their own crate, much like prost-types or prost-wkt. |
Makes sense to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-exporting Google protos from
tendermint_protobecause I couldn't properly upgradeibc-proto-rsto v0.48.0 inibc-rs. Starting with v0.48,ibc-proto-rsno longer includes WKT types, which forcesibc-rsto add atendermint-protodependency in several crates. We're trying to decoupleibc-rsfrom thetendermint-rscrates (except for the ICS-07 Tendermint light client), so this feels like a step back. Ideally,ibc-rsshould stay only dependant onibc-proto-rs.In the future, if
tendermint-protois split into a separate repository and the IBC core proto types are decoupled from thetendermint-protodependency as well, we achieve full separation and avoid any potential dependency conflicts in ibc-rs. Though it's not urgent now, stating it as a longer term goal.