Use the v0.34 definition of tendermint.abci.Event which does not enforce valid UTF-8 data
#180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… UTF-8 data Use the v0.34 definition of `abci.Event` which does not enforce valid UTF-8 data for its `key` and `value` attributes, specifying them as `bytes` instead of `string`. This is required, because ibc-go emits event attributes which are not valid UTF-8, so we need to use this definition to be able to parse them. In Protobuf, `bytes` and `string` are wire-compatible, so doing this strictly increases the amount fo data we can parse.
Merged
7 tasks
|
Here is the diff between --- /tmp/038.rs 2024-01-22 10:37:42
+++ /tmp/034.rs 2024-01-22 10:38:27
@@ -2,10 +2,10 @@
#[allow(clippy::derive_partial_eq_without_eq)]
#[derive(Clone, PartialEq, ::prost::Message)]
pub struct EventAttribute {
- #[prost(string, tag = "1")]
- pub key: ::prost::alloc::string::String,
- #[prost(string, tag = "2")]
- pub value: ::prost::alloc::string::String,
+ #[prost(bytes = "bytes", tag = "1")]
+ pub key: ::prost::bytes::Bytes,
+ #[prost(bytes = "bytes", tag = "2")]
+ pub value: ::prost::bytes::Bytes,
/// nondeterministic
#[prost(bool, tag = "3")]
pub index: bool, |
romac
changed the title
abci.Event which does not enforce valid UTF-8 datatendermint.abci.Event which does not enforce valid UTF-8 data
|
This PR has been confirmed to fix the issue seen in Hermes. |
Farhad-Shabani
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #181
Use the v0.34 definition of
abci.Eventwhich does not enforce valid UTF-8 data for itskeyandvalueattributes, specifying them asbytesinstead ofstring. This is required, because ibc-go emits event attributes which are not valid UTF-8, so we need to use this definition to be able to parse them. In Protobuf,bytesandstringare wire-compatible, so doing this strictly increases the amount fo data we can parse.See this Hermes PR for background information: informalsystems/hermes#3768