Restore generated protos to their specified version #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
changed the title
romac
force-pushed
the
romac/fix-script
branch
from
c223b0a
to
28d5636
Compare
mzabaluev
approved these changes
Sep 27, 2023
| @@ -109,6 +114,90 @@ pub struct ExtensionRangeOptions { | |||
| /// The parser stores options it doesn't recognize here. See above. | |||
| #[prost(message, repeated, tag = "999")] | |||
| pub uninterpreted_option: ::prost::alloc::vec::Vec<UninterpretedOption>, | |||
| /// For external users: DO NOT USE. We are in the process of open sourcing | |||
There was a problem hiding this comment.
Interesting that it checks out different and seemingly newer google protobuf. Ideally though, we should converge on prost-types or some other basic crate to consistently represent these messages.
There was a problem hiding this comment.
Interesting that it checks out different and seemingly newer google protobuf
Yeah I never quite understood why those change so much.
Ideally though, we should converge on prost-types or some other basic crate to consistently represent these messages
Agreed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #122 I mistakenly broke the script that checks out the repositories for the SDK, IBC-Go and ICS at the specified commits. Since then, the script has been checking out the default branch at its latest state instead of the commits specified in the
src/*_COMMITfiles.This PR fixes the script and re-generates the protos for them to match their version.