chore: rename apis to align with spec #7511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
requested review from
colin-axner,
AdityaSripal,
chatton,
DimitrisJim,
gjermundgaraba and
bznein
as code owners
damiannolan
commented
Oct 23, 2024
| @@ -17,7 +17,50 @@ import ( | |||
|
|
|||
| var _ channeltypesv2.MsgServer = &Keeper{} | |||
|
|
|||
| // SendPacket implements the PacketMsgServer SendPacket method. | |||
| // CreateChannel defines a rpc handler method for MsgCreateChannel. | |||
There was a problem hiding this comment.
Moved CreateChannel and RegisterCounterparty to top of file so things read logically wrt exec flow
There was a problem hiding this comment.
I also wanted to move ack after recv 😬 (both here and in packet.go iirc)
damiannolan
commented
Oct 23, 2024
Comment on lines
17
to
21
| _ sdk.Msg = (*MsgRegisterCounterparty)(nil) | ||
| _ sdk.HasValidateBasic = (*MsgRegisterCounterparty)(nil) | ||
|
|
||
| _ sdk.Msg = (*MsgCreateChannel)(nil) | ||
| _ sdk.HasValidateBasic = (*MsgCreateChannel)(nil) |
There was a problem hiding this comment.
maybe I swap these too 🫠
|
Looks like we're missing test func for create channel rpc |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ProvideCounterpartytoRegisterCounterpartyIdk if there's an issue for this. Please link if you know of one!
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.