Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add ValidateBasic for MsgTimeout in ChannelKeeper V2 #7482

Merged
merged 3 commits into from
Oct 18, 2024
Merged

chore: add ValidateBasic for MsgTimeout in ChannelKeeper V2 #7482

merged 3 commits into from
Oct 18, 2024

Conversation

bznein
Copy link
Contributor

@bznein bznein commented Oct 18, 2024 •
edited
Loading

Description

closes: #7466

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@bznein
Copy link
Contributor Author

bznein commented Oct 18, 2024

I think the failing tests are due to #7480

@bznein bznein marked this pull request as ready for review October 18, 2024 10:08
DimitrisJim
DimitrisJim approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for merge conflicts 😬 This should now close umbrella issue?

@bznein
Copy link
Contributor Author

bznein commented Oct 18, 2024

sorry for merge conflicts 😬 This should now close umbrella issue?

Yeah! I'll close as soon as I merge this (I want to let tests run to verify merge went ok)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@bznein bznein merged commit e77a0f4 into feat/ibc-eureka Oct 18, 2024
65 checks passed
@bznein bznein deleted the bznein/7466/validationForMsgTimeout branch October 18, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner colin-axner is a code owner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@damiannolan damiannolan Awaiting requested review from damiannolan damiannolan is a code owner

@chatton chatton Awaiting requested review from chatton chatton is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bznein @DimitrisJim