-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add ValidateBasic and test for MsgRecvPacket #7470
chore: add ValidateBasic and test for MsgRecvPacket #7470
Conversation
@@ -20,6 +22,8 @@ type TypesTestSuite struct { | |||
coordinator *ibctesting.Coordinator | |||
chainA *ibctesting.TestChain | |||
chainB *ibctesting.TestChain | |||
|
|||
proof []byte |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this being used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linter says no! :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but we should remove the IsZero
check on proof height
@@ -20,6 +22,8 @@ type TypesTestSuite struct { | |||
coordinator *ibctesting.Coordinator | |||
chainA *ibctesting.TestChain | |||
chainB *ibctesting.TestChain | |||
|
|||
proof []byte |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linter says no! :D
test cov failure is addressed in a bunch of other PRs (validation for msgsendpacket caused it to fail). Merging this for time being. |
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.