Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reusable metadata validation #729

Merged
merged 24 commits into from
Jan 14, 2022
Merged

refactor: reusable metadata validation #729

merged 24 commits into from
Jan 14, 2022

Commits on Jan 7, 2022

  1. define and generate new metadata proto type

    @damiannolan
    damiannolan committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    e13b08c View commit details
    Browse the repository at this point in the history

  2. refactor types pkg, remove version string parsers, add PortPrefix

    @damiannolan
    damiannolan committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    a5e9947 View commit details
    Browse the repository at this point in the history

  3. refactor ica entrypoint and handshake to handle connection ids in met… 

    …adata
    @damiannolan
    damiannolan committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    a79ab75 View commit details
    Browse the repository at this point in the history

  4. fixing broken test cases

    @damiannolan
    damiannolan committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    f14d4dd View commit details
    Browse the repository at this point in the history

  5. adding controller port and metadata validation, adding new testcases

    @damiannolan
    damiannolan committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    b8b0cbb View commit details
    Browse the repository at this point in the history

  6. updating proto doc and removing commented out code

    @damiannolan
    damiannolan committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    d5380ee View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into damian/615-refactor-ica-connection-ids

    @damiannolan
    damiannolan authored Jan 7, 2022
    Configuration menu
    Copy the full SHA
    873d8cd View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2022

  1. updating testcase names, adding metadata constructor func, updating P… 

    …ortPrefix and removing Delimiter
    @damiannolan
    damiannolan committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    07a506d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into damian/615-refactor-ica-connection-ids

    @damiannolan
    damiannolan authored Jan 10, 2022
    Configuration menu
    Copy the full SHA
    dd95566 View commit details
    Browse the repository at this point in the history

  3. adding ErrInvalidControllerPort and ErrInvalidHostPort

    @damiannolan
    damiannolan committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    264b307 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'damian/615-refactor-ica-connection-ids' of github.com:c… 

    …osmos/ibc-go into damian/615-refactor-ica-connection-ids
    @damiannolan
    damiannolan committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    777ab3b View commit details
    Browse the repository at this point in the history

  5. refactoring metadata validation to reusable func

    @damiannolan
    damiannolan committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    4267799 View commit details
    Browse the repository at this point in the history

  6. returning correct err type

    @damiannolan
    damiannolan committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    6ef8997 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. Merge branch 'main' into damian/615-followup

    @damiannolan
    damiannolan committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    15356d5 View commit details
    Browse the repository at this point in the history

  2. regenerating protos after merge conflicts

    @damiannolan
    damiannolan committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    dc73e95 View commit details
    Browse the repository at this point in the history

  3. adding separate validation funcs for controller and host

    @damiannolan
    damiannolan committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    3257aa4 View commit details
    Browse the repository at this point in the history

  4. correcting error msg in ValidateHostMetadata

    @damiannolan
    damiannolan committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    9dc5386 View commit details
    Browse the repository at this point in the history

  5. updating with review suggestions

    @damiannolan
    damiannolan committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    3a99f1b View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into damian/615-followup

    @damiannolan
    damiannolan authored Jan 13, 2022
    Configuration menu
    Copy the full SHA
    cb74934 View commit details
    Browse the repository at this point in the history

  7. adding additional empty address check to ACK step, adding test case

    @damiannolan
    damiannolan committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    2214791 View commit details
    Browse the repository at this point in the history

  8. adding strings.Trimspace

    @damiannolan
    damiannolan committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    8d34265 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. adding success with empty address testcase for ValidateHostMetadata

    @damiannolan
    damiannolan committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    69411d0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into damian/615-followup

    @damiannolan
    damiannolan committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    f321d07 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into damian/615-followup

    @damiannolan
    damiannolan committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    d72b263 View commit details
    Browse the repository at this point in the history