chore (api)!: remove capabilities from SendPacket

[bznein]

Description

closes: #XXXX

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against the correct branch (see CONTRIBUTING.md).
• Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
• Code follows the module structure standards and Go style guide.
• Wrote unit and integration tests.
• Updated relevant documentation (docs/).
• Added relevant godoc comments.
• Provide a conventional commit message to follow the repository standards.
• Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
• Re-reviewed Files changed in the GitHub PR explorer.
• Review SonarCloud Report in the comment section below once CI passes.

[colin-axner]

Woo! Great work! 🎉

For reference to other viewers. While we have not adjusted the SendPacket to go through an rpc on core IBC, this is still safe to remove as we rely on the security principles guarded by the bank keeper. Modules which can access the go api must not be malicious (otherwise they can send coins from any account to any other account). The same principle is being applied by removing this code. It was always true that a malicious module could bypass the channel capability anyways (by embedding the scoped keeper of another module)

[colin-axner]

We will need to add a changelog + migration docs, but happy to do that at the end. Maybe we can make a note on the remove capabilities issue

[bznein]

It's probably better to have this one merged #7089 before we merge any removal of capabilities, to avoid merge conflicts on that PR

[damiannolan]

Nice 🔴 diffs!

[chatton]

🪓 love the diff!

[DimitrisJim]

It's probably better to have this one merged #7089 before we merge any removal of capabilities,

I'd say go for the merge and dont let other PR block you (currently reviewing it that and trying to find some issue with tests, I'll take care of merge conflicts there)

[sonarcloud]

Quality Gate passed for 'ibc-go'

Issues
120 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud