refactor: remove ics27 channel capability migration introduced in v6 #7053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
requested review from
AdityaSripal,
crodriguezvega,
damiannolan,
chatton,
DimitrisJim,
srdtrk,
gjermundgaraba and
bznein
as code owners
DimitrisJim
approved these changes
Aug 5, 2024
| @@ -24,8 +21,6 @@ import ( | |||
| const ( | |||
| // V5 defines the upgrade name for the ibc-go/v5 upgrade handler. | |||
| V5 = "normal upgrade" // NOTE: keeping as "normal upgrade" as existing tags depend on this name | |||
| // V6 defines the upgrade name for the ibc-go/v6 upgrade handler. | |||
There was a problem hiding this comment.
small aside, don't see V5 being used anywhere either.
| @@ -77,6 +77,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
| * (light-clients/06-solomachine, light-clients/07-tendermint) [\#6891](https://github.com/cosmos/ibc-go/pull/6891) The `VerifyMembership` and `VerifyNonMembership` functions of solomachine's `ClientState` have been made private. The `VerifyMembership`, `VerifyNonMembership`, `GetTimestampAtHeight`, `Status` and `Initialize` functions of tendermint's `ClientState` have been made private. | |||
| * (core/04-channel) [\#6902](https://github.com/cosmos/ibc-go/pull/6902) Add channel version to core application callbacks. | |||
| * (core/24-host) [\#6882](https://github.com/cosmos/ibc-go/issues/6882) All functions ending in `Path` have been removed from 24-host in favour of their sybling functions ending in `Key`. | |||
| * (apps/27-interchain-accounts) [\#7053](https://github.com/cosmos/ibc-go/pull/7053) Remove ICS27 channel capability migration introduced in v6. | |||
There was a problem hiding this comment.
this should be changelog for v9 no?
There was a problem hiding this comment.
Yes, but I think this might be true of other changes as well? I was assuming there would be one pr later to split things up
…s/ibc-go into colin/7051-ics27-migration-removal
damiannolan
approved these changes
Aug 7, 2024
v10! |
…s/ibc-go into colin/7051-ics27-migration-removal
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
…-migration-removal
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #7051
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.