Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(e2e): ics20 v2 multidenom #6290

Merged
merged 56 commits into from
Jun 17, 2024
Merged

Commits on Apr 8, 2024

  1. Adding proto files for ics20-v2 (#6110)

    * chore: adding proto files for ics20-v2
    
    * chore: add newline
    chatton authored Apr 8, 2024
    Configuration menu
    Copy the full SHA
    c07bca9 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Configuration menu
    Copy the full SHA
    e66bd89 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    034f472 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Configuration menu
    Copy the full SHA
    4cc6a85 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. imp: add CurrentVersion, EscrowVersion (#6160)

    * add CurrentVersion, EscrowVersion, update tests
    
    * update hardcoded transfer channel version from interchaintest
    charleenfei authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    71f830c View commit details
    Browse the repository at this point in the history
  2. chore: add function for converting packet data from v1 to v3 (#6116)

    ---------
    
    Co-authored-by: Charly <charly@interchain.berlin>
    chatton and charleenfei authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    28ff9b6 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Configuration menu
    Copy the full SHA
    4e55137 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. imp: getMultiDenomFungibleTokenPacketDatato be used in packet unmar…

    …shalling/conversion (#6226)
    
    * chore: adding proto files for ics20-v2
    
    * chore: add newline
    
    * chore: modify MsgTransfer to accept coins instead of coin
    
    * chore: reverted unintentional comment changes
    
    * chore: reverted unintentional comment changes
    
    * chore: adding test for conversion fn
    
    * chore: fix e2e linter
    
    * chore: adding docs
    
    * chore: addressing PR feedback
    
    * chore: remove duplicate import
    
    * chore: addressing PR feedback
    
    * chore: moved extration logic into internal package
    
    * chore: commented out failing test
    
    * chore: adding link to issue
    
    * chore: remove duplicate import
    
    * chore: fix linting errors
    
    * FungibleTokenPacketData interface methods + tests
    
    * linter
    
    * wip: token validation
    
    * update trace identifier validation in Token + tests
    
    * rm Printf
    
    * update with pr review
    
    * add CurrentVersion, EscrowVersion, update tests
    
    * pr review
    
    * fix e2e tests
    
    * pr review
    
    * update e2e test version
    
    * linter
    
    * update hardcoded transfer channel version from interchaintest
    
    * update hardcoded transfer channel version from interchaintest
    
    * wip packet unmarshaller
    
    * wip
    
    * wip testing
    
    * update test
    
    * linter
    
    * rm unnecessary version changes
    
    * rm unnecessary artifacts
    
    * update callbacks test
    
    * update comment
    
    * pr review
    
    * rename getMultiDenomFungibleTokenPacketData to unmarshalPacketDataBytesToICS20V2
    
    ---------
    
    Co-authored-by: chatton <github.qpeyb@simplelogin.fr>
    Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
    3 people authored Apr 29, 2024
    Configuration menu
    Copy the full SHA
    ca056cf View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. chore: implement version checking for channel handshake application c…

    …allbacks (#6175)
    
    * add SupportedVersions array for different ics20 versions, add version checking on channel handshake application callbacks
    
    * add tests
    
    * update pr review
    
    * pr review
    
    * last few pr review nits
    
    * linter
    
    * add version counter proposing
    
    * fix missing app versino
    
    * update code + tests to return our proposed version if counterparty version is invalid
    
    * remove if statement
    
    * address review comments: return ics20-2 if counterparty version is not supported
    
    ---------
    
    Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
    charleenfei and crodriguezvega authored May 6, 2024
    Configuration menu
    Copy the full SHA
    147cf17 View commit details
    Browse the repository at this point in the history
  2. imp: update transfer authz implementation to account for multi denom …

    …transfers (#6252)
    
    * add transfer authz code + tests
    
    * linter
    
    * address review comments
    
    ---------
    
    Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
    charleenfei and crodriguezvega authored May 6, 2024
    Configuration menu
    Copy the full SHA
    9bbfa1a View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. ics20-v2: backwards compatibility for transfer rpc and packet callbac…

    …ks (#6189)
    
    * chore: adding proto files for ics20-v2
    
    * chore: add newline
    
    * chore: modify MsgTransfer to accept coins instead of coin
    
    * chore: reverted unintentional comment changes
    
    * chore: reverted unintentional comment changes
    
    * chore: adding test for conversion fn
    
    * chore: fix e2e linter
    
    * chore: adding docs
    
    * chore: addressing PR feedback
    
    * chore: remove duplicate import
    
    * chore: addressing PR feedback
    
    * chore: moved extration logic into internal package
    
    * chore: commented out failing test
    
    * chore: adding link to issue
    
    * chore: remove duplicate import
    
    * chore: fix linting errors
    
    * FungibleTokenPacketData interface methods + tests
    
    * linter
    
    * wip: token validation
    
    * update trace identifier validation in Token + tests
    
    * rm Printf
    
    * update with pr review
    
    * pr review
    
    * linter
    
    * rm unused function: linter
    
    * wip pr feedback
    
    * fix test
    
    * pr review
    
    * lintttttt
    
    * wip: backwards compatibility for transfer rpc
    
    * implement changes for ics20-v2 packet data for onRecvPacket, onAcknowledgePacket and onTimeoutPacket
    
    * fix callbacks tests
    
    * lint
    
    ---------
    
    Co-authored-by: chatton <github.qpeyb@simplelogin.fr>
    Co-authored-by: Charly <charly@interchain.berlin>
    3 people authored May 10, 2024
    Configuration menu
    Copy the full SHA
    4f57916 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b4244f9 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2024

  1. some fixes

    crodriguezvega committed May 12, 2024
    Configuration menu
    Copy the full SHA
    b09f5d7 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Configuration menu
    Copy the full SHA
    4c333c5 View commit details
    Browse the repository at this point in the history
  2. lint

    crodriguezvega committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8b55295 View commit details
    Browse the repository at this point in the history
  3. import renaming

    crodriguezvega committed May 14, 2024
    Configuration menu
    Copy the full SHA
    0478cb9 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Configuration menu
    Copy the full SHA
    f39d173 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9b39944 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    06ca9a5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7897ef3 View commit details
    Browse the repository at this point in the history
  5. lint

    colin-axner committed May 21, 2024
    Configuration menu
    Copy the full SHA
    786a4f1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3a162ea View commit details
    Browse the repository at this point in the history
  7. Merge pull request #6346 from cosmos/merge-main

    Sync feature with main branch
    DimitrisJim authored May 21, 2024
    Configuration menu
    Copy the full SHA
    5747756 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Configuration menu
    Copy the full SHA
    7e2e6df View commit details
    Browse the repository at this point in the history
  2. imp: change ics20 events to emit token set (#6348)

    * refactor: quick change to tokens event attribute
    
    * fix: various tests
    
    * lint
    
    * lint:fixeroni
    
    * imp: remove events variable in favour of direct event emission
    
    ---------
    
    Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
    colin-axner and DimitrisJim authored May 22, 2024
    Configuration menu
    Copy the full SHA
    a84b0e7 View commit details
    Browse the repository at this point in the history
  3. imp: check length tokens array against maximum allowed (#6349)

    * check length of tokens array against maximum allowed
    
    * chore: add note on arbitrary selection
    
    ---------
    
    Co-authored-by: Colin Axnér <25233464+colin-axner@users.noreply.github.com>
    crodriguezvega and colin-axner authored May 22, 2024
    Configuration menu
    Copy the full SHA
    43877df View commit details
    Browse the repository at this point in the history
  4. Modify UnmarshalPacketData interface to allow additional args (#6341)

    * api(port)!: Allow passing of context, port and channel identifier to unmarshal packet data interface as disussed.
    
    This allows us to grab the app version in transfer and unmarshal the packet based on that instead of a hacky unmarshal v2 then v1 and whatever happens.
    
    * lint: as we do
    
    * callbacks: fix signature of UnmarshalPacketData as per changes, make refactors to hopefully simplify signatures.
    
    * chore: lint and remove some todos.
    
    * review: address feedback.
    DimitrisJim authored May 22, 2024
    Configuration menu
    Copy the full SHA
    8eae033 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Refactor packet data unmarshalling to use specific version (#6354)

    * chore: specifically unmarshal v1 or v2 without brute force
    
    * chore: fix TestPacketDataUnmarshalerInterface test in transfer module
    
    * Pass dest values OnRecv, refactor GetExpectedEvents
    
    * chore: fixing TestGetCallbackData test
    
    * chore: fixed remaining tests in callbacks module
    
    * test: simplify callbacks test, revert back to previous behaviour
    
    * chore: fix test case name
    
    * chore: addressing PR feedback
    
    * chore: added docstring for unmarshalPacketDataBytesToICS20V2
    
    ---------
    
    Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
    Co-authored-by: Colin Axnér <25233464+colin-axner@users.noreply.github.com>
    3 people authored May 23, 2024
    Configuration menu
    Copy the full SHA
    dbcff45 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bb69698 View commit details
    Browse the repository at this point in the history
  3. chore: fixing tests

    chatton committed May 23, 2024
    Configuration menu
    Copy the full SHA
    f19a145 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #6359 from cosmos/merge-main-2

    Sync Feature Branch With Main
    chatton authored May 23, 2024
    Configuration menu
    Copy the full SHA
    8f86dda View commit details
    Browse the repository at this point in the history
  5. imp: self review comments for ics20-v2 (#6360)

    * refactor: address various self review comments
    
    * revert: unnecessary change
    
    * lint
    colin-axner authored May 23, 2024
    Configuration menu
    Copy the full SHA
    d4b06c8 View commit details
    Browse the repository at this point in the history
  6. imp: self review on ics20-v2 part 2 (#6364)

    * refactor: apply review suggestions
    
    * imp: additional updates
    
    * refactor: make ValidateIBCDenom private
    
    * Update modules/apps/transfer/types/msgs.go
    
    Co-authored-by: Cian Hatton <cian@interchain.io>
    
    * apply review suggestions
    
    ---------
    
    Co-authored-by: Cian Hatton <cian@interchain.io>
    colin-axner and chatton authored May 23, 2024
    Configuration menu
    Copy the full SHA
    a9391a4 View commit details
    Browse the repository at this point in the history
  7. chore: move functions from internal/denom back to trace.go (#6368)

    * chore: move functions from internal/denom to trace.go
    
    * lint
    
    * lint: the comeback
    DimitrisJim authored May 23, 2024
    Configuration menu
    Copy the full SHA
    575403e View commit details
    Browse the repository at this point in the history
  8. imp: ics20 v2 self review part 3 (#6373)

    * imp: self review items
    
    * apply jim's suggestion
    
    * Update modules/apps/transfer/keeper/msg_server_test.go
    
    * Update modules/apps/transfer/ibc_module.go
    
    * Update modules/apps/transfer/ibc_module.go
    colin-axner authored May 23, 2024
    Configuration menu
    Copy the full SHA
    50ccd94 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    87eb32e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    e8b9d5a View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Refactor msgs_test.go to use expError (#6367)

    * chore: refactoring msgs_test.go to use expError
    
    * chore: updating expected errors
    
    * chore: update MsgUpdateParams and lint
    
    ---------
    
    Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
    chatton and DimitrisJim authored May 24, 2024
    Configuration menu
    Copy the full SHA
    6d40bc6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c171059 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Configuration menu
    Copy the full SHA
    a276219 View commit details
    Browse the repository at this point in the history
  2. use new queries in e2e

    crodriguezvega committed May 27, 2024
    Configuration menu
    Copy the full SHA
    d55c817 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3319e42 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Merge branch 'main' into carlos/e2e-tests-multidenom

    # Conflicts:
    #	e2e/testsuite/testsuite.go
    #	e2e/testsuite/tx.go
    crodriguezvega committed May 28, 2024
    Configuration menu
    Copy the full SHA
    0d0b5fc View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Configuration menu
    Copy the full SHA
    a284934 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Configuration menu
    Copy the full SHA
    2dafbd5 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Merge branch 'main' into carlos/e2e-tests-multidenom

    # Conflicts:
    #	e2e/tests/core/02-client/client_test.go
    #	e2e/tests/core/03-connection/connection_test.go
    #	e2e/tests/transfer/base_test.go
    #	e2e/tests/transfer/localhost_test.go
    #	e2e/tests/transfer/upgrades_test.go
    #	e2e/tests/upgrades/genesis_test.go
    #	e2e/tests/upgrades/upgrade_test.go
    #	e2e/testsuite/testsuite.go
    #	e2e/testsuite/tx.go
    crodriguezvega committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    2485db0 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2024

  1. Configuration menu
    Copy the full SHA
    6886e3b View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2024

  1. Configuration menu
    Copy the full SHA
    14d17ff View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Configuration menu
    Copy the full SHA
    3f12a8e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    087d52f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    feb2383 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Configuration menu
    Copy the full SHA
    bdd4ab6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    70f9b8c View commit details
    Browse the repository at this point in the history
  3. fix value comparison

    crodriguezvega committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    7d42ff3 View commit details
    Browse the repository at this point in the history
  4. review comments

    crodriguezvega committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    d4bd933 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fbb6994 View commit details
    Browse the repository at this point in the history