Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: implement version checking for channel handshake application callbacks #6175

Merged
merged 11 commits into from
May 6, 2024
Merged

chore: implement version checking for channel handshake application callbacks #6175

merged 11 commits into from
May 6, 2024

Commits on Apr 16, 2024

  1. add SupportedVersions array for different ics20 versions, add version… 

    … checking on channel handshake application callbacks
    @charleenfei
    charleenfei committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    f741403 View commit details
    Browse the repository at this point in the history

  2. add tests

    @charleenfei
    charleenfei committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    daa0b32 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. update pr review

    @charleenfei
    charleenfei committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    40337d8 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. pr review

    @charleenfei
    charleenfei committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    a6238ce View commit details
    Browse the repository at this point in the history

  2. last few pr review nits

    @charleenfei
    charleenfei committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    2dbf77b View commit details
    Browse the repository at this point in the history

  3. linter

    @charleenfei
    charleenfei committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    ac271fa View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. add version counter proposing

    @charleenfei
    charleenfei committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    1166258 View commit details
    Browse the repository at this point in the history

  2. fix missing app versino

    @charleenfei
    charleenfei committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    8bc703a View commit details
    Browse the repository at this point in the history

  3. update code + tests to return our proposed version if counterparty ve… 

    …rsion is invalid
    @charleenfei
    charleenfei committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    e5f3d73 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. remove if statement

    @crodriguezvega
    crodriguezvega committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    90cca94 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. address review comments: return ics20-2 if counterparty version is no… 

    …t supported
    @crodriguezvega
    crodriguezvega committed May 5, 2024
    Configuration menu
    Copy the full SHA
    021e42f View commit details
    Browse the repository at this point in the history