-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp: add logic for setting NextSeqRecv
, NextSeqAck
in OnChanUpgradeOpen
#5438
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
b7fbb39
add logic for setting next seq recv, update tests
charleenfei a3a10ab
update next seq recv and ack logic to spec
charleenfei 045fdd2
Merge branch '04-channel-upgrades' into charly/set_nextseqrecv
charleenfei 129cc62
typos
charleenfei c95192b
update test
charleenfei d7379a0
Merge branch 'charly/set_nextseqrecv' of github.com:cosmos/ibc-go int…
charleenfei 972faa6
wip changes for spec
charleenfei 3864e91
wip set counterparty upgrade
charleenfei 122c25b
update naming
charleenfei 81c31ee
update endpoint
charleenfei 0ca4bca
spec changes
charleenfei a7a0834
test that counterparty upgrade has been set
charleenfei adaac86
Merge branch '04-channel-upgrades' into charly/set_nextseqrecv
charleenfei 9a6f4c1
update err message
charleenfei ed80a45
pr review
charleenfei 1dd6dcd
Merge branch 'charly/set_nextseqrecv' of github.com:cosmos/ibc-go int…
charleenfei 7b2b487
naming nit
crodriguezvega 4fcc075
Merge branch '04-channel-upgrades' into charly/set_nextseqrecv
charleenfei 70973c9
pr review
charleenfei c6cd056
Merge branch '04-channel-upgrades' into charly/set_nextseqrecv
charleenfei 9e96b13
refactor test
charleenfei 09fafce
Merge branch 'charly/set_nextseqrecv' of github.com:cosmos/ibc-go int…
charleenfei 8fdc927
small test changes
charleenfei 7d7f60a
lint
charleenfei 608d9e2
Add key for storing counterparty next sequence send during WriteUpgra…
DimitrisJim add52f8
Merge branch '04-channel-upgrades' into charly/set_nextseqrecv
charleenfei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i removed these tests bc we aren't checking these sequences in
RecvPacket
anymore