e2e: successful test where the channel is upgraded and fee middleware is enabled #5358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st-where-the-channel-is-upgraded-and-fee-middleware-is-enabled
…st-where-the-channel-is-upgraded-and-fee-middleware-is-enabled
crodriguezvega
requested review from
colin-axner,
AdityaSripal,
charleenfei,
damiannolan,
chatton and
DimitrisJim
as code owners
crodriguezvega
commented
Dec 12, 2023
| @@ -12,20 +12,20 @@ require ( | |||
| github.com/cosmos/ibc-go/modules/light-clients/08-wasm v0.0.0-00010101000000-000000000000 | |||
| github.com/cosmos/ibc-go/v8 v8.0.0 | |||
| github.com/docker/docker v24.0.7+incompatible | |||
| github.com/strangelove-ventures/interchaintest/v8 v8.0.0 | |||
| github.com/strangelove-ventures/interchaintest/v8 v8.0.1-0.20231206154526-2f014d308bea | |||
There was a problem hiding this comment.
I needed to bump interchaintest to get this PR that added support for a new field (chain type) that has been added to hermes config.toml.
| s.Require().NoError(err) | ||
| s.Require().Equal(true, feeEnabled) | ||
| }) | ||
| } |
There was a problem hiding this comment.
I could try to send some incentivised packets, but I thought that the checks above were already enough.
|
Grandpa tests are failing, need to check what's going on there now. |
…st-where-the-channel-is-upgraded-and-fee-middleware-is-enabled
colin-axner
approved these changes
Dec 14, 2023
9 tasks
…st-where-the-channel-is-upgraded-and-fee-middleware-is-enabled
damiannolan
approved these changes
Dec 18, 2023
| @@ -30,7 +30,7 @@ relayers: | |||
| tag: "latest" | |||
| - id: hyperspace | |||
| image: ghcr.io/misko9/hyperspace | |||
| tag: "timeout" | |||
| tag: "20231122v39" | |||
…st-where-the-channel-is-upgraded-and-fee-middleware-is-enabled
crodriguezvega
deleted the
carlos/5357-successful-e2e-test-where-the-channel-is-upgraded-and-fee-middleware-is-enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Work in progress: I need a new docker image from the relayer that Luca is building as we speak.Test passing here. 🥳
closes: #5357
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.