Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pr labeler. #5302

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Remove pr labeler. #5302

merged 5 commits into from
Dec 5, 2023

Conversation

DimitrisJim
Copy link
Contributor

@DimitrisJim DimitrisJim commented Dec 4, 2023

Description

got some breaking changes apparently, opening in draft until I get config playing well.

closes: #XXXX

Commit Message / Changelog Entry

chore: remove labeler workflow.

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@DimitrisJim DimitrisJim force-pushed the jim/labeler-to-5.0.0 branch 4 times, most recently from 2fa2571 to 00f7c5c Compare December 4, 2023 15:14
@damiannolan
Copy link
Member

damiannolan commented Dec 5, 2023

Personally I do not find the PR labeler that useful and would be in favour of removing it if this is not worth the time to resolve.

On one hand the PR labeler can be somewhat useful, but I find adding labels manually to be similarly as effective - what I don't like how many labels get added to larger PRs and add more visual noise.

@DimitrisJim DimitrisJim changed the title Pin labeler to 5.0.0, update config. Remove pr labeler. Dec 5, 2023
@DimitrisJim DimitrisJim marked this pull request as ready for review December 5, 2023 14:34
@DimitrisJim DimitrisJim added the github_actions Pull requests that update Github_actions code label Dec 5, 2023
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You labeled me, I'll label you. So I dub thee unforgiven!

Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't put a label on everything.

@DimitrisJim DimitrisJim merged commit 0b40489 into main Dec 5, 2023
60 of 62 checks passed
@DimitrisJim DimitrisJim deleted the jim/labeler-to-5.0.0 branch December 5, 2023 14:48
damiannolan added a commit that referenced this pull request Dec 5, 2023
Remove labeler workflow.

---------

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants