Change to StoreCodeUnchecked in Genesis and snapshotter (backport #5167) #5241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* change to store code unchecked * separate storeWasmCode and importWasmCode * add parameter to storeWasmCode to pass the store function * store code for msg server * fix: typos in godocs * Update modules/light-clients/08-wasm/internal/ibcwasm/expected_interfaces.go Co-authored-by: Damian Nolan <damiannolan@gmail.com> * linting business --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit 10bb80b) # Conflicts: # modules/light-clients/08-wasm/keeper/keeper.go # modules/light-clients/08-wasm/keeper/snapshotter.go
mergify
bot
requested review from
colin-axner,
AdityaSripal,
damiannolan and
charleenfei
as code owners
mergify
bot
requested review from
chatton,
DimitrisJim and
srdtrk
as code owners
…o mergify/bp/08-wasm/release/v0.1.x+ibc-go-v7.3.x-wasmvm-v1.4.x/pr-5167
damiannolan
reviewed
Nov 29, 2023
| @@ -10,7 +10,7 @@ import ( | |||
| // state. | |||
| func (k Keeper) InitGenesis(ctx sdk.Context, gs types.GenesisState) error { | |||
| for _, contract := range gs.Contracts { | |||
| _, err := k.storeWasmCode(ctx, contract.CodeBytes) | |||
| _, err := k.storeWasmCode(ctx, contract.CodeBytes, k.wasmVM.StoreCodeUnchecked) | |||
There was a problem hiding this comment.
note: these calls to k.wasmVM.FuncCall should be replaced with ibcwasm.GetVM() in another backport so that all are consistent
DimitrisJim
approved these changes
Nov 29, 2023
damiannolan
merged commit 4a08ef9
into
08-wasm/release/v0.1.x+ibc-go-v7.3.x-wasmvm-v1.4.x
17 checks passed
damiannolan
deleted the
mergify/bp/08-wasm/release/v0.1.x+ibc-go-v7.3.x-wasmvm-v1.4.x/pr-5167
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #5167 done by Mergify.
Cherry-pick of 10bb80b has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com