Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to docstring with explanation about channel state #5236

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Add to docstring with explanation about channel state #5236

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
120c29a
chore: added docstring with state explainations
chatton Nov 29, 2023
09083bb
chore: fix linter
chatton Nov 29, 2023
0b79bcc
Merge branch '04-channel-upgrades' into cian/issue#5220-add-comment-f…
chatton Nov 29, 2023
19da0cc
Merge branch '04-channel-upgrades' into cian/issue#5220-add-comment-f…
chatton Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions modules/core/04-channel/keeper/upgrade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,14 @@ func (k Keeper) WriteUpgradeTryChannel(ctx sdk.Context, portID, channelID string
// This method should only be called by the IBC core msg server.
// This method will verify that the counterparty has called the ChanUpgradeTry handler.
// and that its own upgrade is compatible with the selected counterparty version.
// NOTE: the channel may be in either the OPEN or FLUSHING state.
// The channel may be in OPEN if we are in the happy path.
//
// A -> Init (OPEN), B -> Try (FLUSHING), A -> Ack (begins in OPEN)
//
// The channel may be in FLUSHING if we are in a crossing hellos situation.
//
// A -> Init (OPEN), B -> Init (OPEN) -> A -> Try (FLUSHING), B -> Try (FLUSHING), A -> Ack (begins in FLUSHING)
func (k Keeper) ChanUpgradeAck(
ctx sdk.Context,
portID,
Expand Down
Loading