-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make linter happy for 08-wasm #4369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume tests are expected to be failing at the moment.
Nice clean up tho! LGTM
@@ -31,7 +31,7 @@ func newStoreCodeCmd() *cobra.Command { | |||
|
|||
fileName := args[0] | |||
|
|||
code, err := ioutil.ReadFile(fileName) | |||
code, err := os.ReadFile(fileName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -3,7 +3,7 @@ package keeper_test | |||
import ( | |||
"testing" | |||
|
|||
"github.com/stretchr/testify/suite" | |||
testifysuite "github.com/stretchr/testify/suite" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct me if I'm wrong, but was this aliased before as testsuite
someplace else or am I mistaken?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, slightly confused me too tbh, testsuite
is another package in the e2e module. In that big linter PR, we went with testifysuite
to try to differentiate from that one too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay sounds good to me!
@@ -6,7 +6,7 @@ import ( | |||
"testing" | |||
"time" | |||
|
|||
"github.com/stretchr/testify/suite" | |||
testifysuite "github.com/stretchr/testify/suite" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto on alias
Description
pleases the linter
closes: #XXXX
Commit Message / Changelog Entry
chore: if anything, this PR was definitely a chore
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.