Make linter happy for 08-wasm #4369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
crodriguezvega
approved these changes
Aug 17, 2023
damiannolan
approved these changes
Aug 17, 2023
| @@ -31,7 +31,7 @@ func newStoreCodeCmd() *cobra.Command { | |||
|
|
|||
| fileName := args[0] | |||
|
|
|||
| code, err := ioutil.ReadFile(fileName) | |||
| code, err := os.ReadFile(fileName) | |||
| @@ -3,7 +3,7 @@ package keeper_test | |||
| import ( | |||
| "testing" | |||
|
|
|||
| "github.com/stretchr/testify/suite" | |||
| testifysuite "github.com/stretchr/testify/suite" | |||
There was a problem hiding this comment.
correct me if I'm wrong, but was this aliased before as testsuite someplace else or am I mistaken?
There was a problem hiding this comment.
yea, slightly confused me too tbh, testsuite is another package in the e2e module. In that big linter PR, we went with testifysuite to try to differentiate from that one too.
| @@ -6,7 +6,7 @@ import ( | |||
| "testing" | |||
| "time" | |||
|
|
|||
| "github.com/stretchr/testify/suite" | |||
| testifysuite "github.com/stretchr/testify/suite" | |||
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pleases the linter
closes: #XXXX
Commit Message / Changelog Entry
chore: if anything, this PR was definitely a choresee the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.