Create Parent Genesis and Tests #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaSripal
requested review from
colin-axner and
fedekunze
as code owners
|
This pull request introduces 1 alert when merging 8117883 into 6e5ba90 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging c92c55c into 6e5ba90 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging d990260 into 6e5ba90 - view on LGTM.com new alerts:
|
colin-axner
reviewed
Sep 22, 2021
| data ccv.ValidatorSetChangePacketData | ||
| ) | ||
| if err := ccv.ModuleCdc.UnmarshalJSON(packet.GetData(), &data); err != nil { | ||
| ack = channeltypes.NewErrorAcknowledgement(fmt.Sprintf("cannot unmarshal CCV packet data: %s", err.Error())) | ||
| errAck := channeltypes.NewErrorAcknowledgement(fmt.Sprintf("cannot unmarshal CCV packet data: %s", err.Error())) |
There was a problem hiding this comment.
The error acknowledgement message cannot contain the unmarshal json error string
| @@ -322,24 +322,21 @@ func (am AppModule) OnRecvPacket( | |||
| _ sdk.AccAddress, | |||
| ) ibcexported.Acknowledgement { | |||
| var ( | |||
| ack ibcexported.Acknowledgement | |||
| ack *channeltypes.Acknowledgement | |||
There was a problem hiding this comment.
why is this a pointer?
| data ccv.ValidatorSetChangePacketData | ||
| ) | ||
| if err := ccv.ModuleCdc.UnmarshalJSON(packet.GetData(), &data); err != nil { | ||
| ack = channeltypes.NewErrorAcknowledgement(fmt.Sprintf("cannot unmarshal CCV packet data: %s", err.Error())) | ||
| errAck := channeltypes.NewErrorAcknowledgement(fmt.Sprintf("cannot unmarshal CCV packet data: %s", err.Error())) | ||
| ack = &errAck |
There was a problem hiding this comment.
why is errAck initialized instead of being assigned directly to ack
| } | ||
|
|
||
| ctx.EventManager().EmitEvent( | ||
| sdk.NewEvent( | ||
| ccv.EventTypePacket, | ||
| sdk.NewAttribute(sdk.AttributeKeyModule, types.ModuleName), | ||
| sdk.NewAttribute(ccv.AttributeKeyAckSuccess, fmt.Sprintf("%t", ack.Success())), | ||
| sdk.NewAttribute(ccv.AttributeKeyAckSuccess, fmt.Sprintf("%t", ack != nil)), |
There was a problem hiding this comment.
This returns true even on an error acknowledgement
| } | ||
| // IterateChannelToChain iterates over the channel to chain mappings and calls the provided callback until the iteration ends | ||
| // or the callback returns stop=true | ||
| func (k Keeper) IterateChannelToChain(ctx sdk.Context, cb func(ctx sdk.Context, channelID, chainID string) (stop bool)) { |
There was a problem hiding this comment.
this func needs a test
| } | ||
| } | ||
|
|
||
| func (k Keeper) ExportGenesis(ctx sdk.Context) types.ParentGenesisState { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #431
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes