Use hasConsensusState instead of GetConsensusState #4171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
colin-axner
reviewed
Jul 25, 2023
DimitrisJim
force-pushed
the
jim/4010-get-to-has
branch
from
e4ccae4
to
db3eefb
Compare
colin-axner
approved these changes
Jul 26, 2023
crodriguezvega
approved these changes
Jul 27, 2023
DimitrisJim
merged commit 518291d
into
carlos/3957-remove-timestamp-from-consensusstate-and-query-contract-to-retrieve-it
49 of 50 checks passed
crodriguezvega
added a commit
that referenced
this pull request
Aug 1, 2023
…etrieve it (#4034) * imp: remove timestamp from consensus state * more linting * make types unexported * make proto-all * code hash for code id * Use hasConsensusState instead of GetConsensusState (#4171) * Use hasConsensusState instead of GetConsensusState. * Use wasmQuery for the rest of the query functions. (#4176) * Use wasmQuery for the rest of the query functions. --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * review comments * Remove check for consensus state. * Add linting for 08-wasm module (#4206) * Add linting for 08-wasm. * Go mod tidy. * Please the linter. * add 08-wasm global store key (#4185) * add 08-wasm global store key * Update client_state.go * Update modules/light-clients/08-wasm/types/vm.go Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> --------- Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> * solve conflicts * review comments/fix linter warnings * address comments * add missing check * remove check that was wrong --------- Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #4010
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.