Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unused simapp tests #4168

Merged
merged 3 commits into from
Jul 25, 2023
Merged

test: remove unused simapp tests #4168

merged 3 commits into from
Jul 25, 2023

Conversation

colin-axner
Copy link
Contributor

Description

Removes all _test.go files in simapp directory as these are currently untested. These files were initially copied from the SDK, but have not been added to our testing workflow and do not add any additional code coverage that the SDK doesn't have. They have been removed to ease maintenance burden

closes: #4167

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gladly

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧼

@colin-axner colin-axner enabled auto-merge (squash) July 25, 2023 10:34
@colin-axner colin-axner merged commit ac6300b into main Jul 25, 2023
22 checks passed
@colin-axner colin-axner deleted the colin/4167-simapp-tests branch July 25, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove simapp auxiliary tests (benchmarking, sim_test)
4 participants