-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renaming to align with x/wasm naming #4091
Changes from 1 commit
29b916d
92eda7b
01b8a46
3bf8827
9aa0489
76358c6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,6 @@ package ibc.lightclients.wasm.v1; | |
option go_package = "github.com/cosmos/ibc-go/modules/light-clients/08-wasm/types"; | ||
|
||
import "cosmos/msg/v1/msg.proto"; | ||
import "gogoproto/gogo.proto"; | ||
|
||
// Msg defines the ibc/08-wasm Msg service. | ||
service Msg { | ||
|
@@ -19,12 +18,12 @@ message MsgStoreCode { | |
option (cosmos.msg.v1.signer) = "signer"; | ||
|
||
string signer = 1; | ||
// WASMByteCode can be raw or gzip compressed | ||
bytes wasm_byte_code = 2 [(gogoproto.customname) = "WASMByteCode"]; | ||
// wasm byte code of light client contract. It can be raw or gzip compressed | ||
bytes wasm_byte_code = 2; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. didn't you want to keep the gogoproto custom name? https://github.com/CosmWasm/wasmd/blob/main/proto/cosmwasm/wasm/v1/tx.proto#L83 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, I thought you preferred to have the field name as |
||
} | ||
|
||
// MsgStoreCodeResponse defines the response type for the StoreCode rpc | ||
message MsgStoreCodeResponse { | ||
// Checksum is the sha256 hash of the stored code | ||
// the sha256 hash of the stored code | ||
bytes checksum = 1; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto on protodoc lowercase nit |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only nit pertains to err message used here, doesn't really give indication that
32
refers to # of bytes.